Issue 9478027: spawnUri: fixing test with recent support for multi-script tests.

Issue 9478027: spawnUri: fixing test with recent support for multi-script tests. (Closed)

Created:
8 years, 9 months ago by Siggi Cherem (dart-lang)

Modified:
8 years, 9 months ago

Reviewers:
eub

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

spawnUri: fixing test with recent support for multi-script tests. Committed: https://code.google.com/p/dart/source/detail?r=4726

Patch Set 4 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -19 lines)			Patch
M	lib/isolate/frog/isolateimpl.dart	View	1 2 3	3 chunks	+12 lines, -3 lines	0 comments	Download
M	lib/isolate/isolate_frog.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/isolate/isolate.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/isolate/src/APIv2_spawnUriBrowserNegativeTest.dart	View	1 2 3	1 chunk	+9 lines, -6 lines	0 comments	Download
M	tests/isolate/src/APIv2_spawnUriBrowserTest.dart	View	1 2 3	1 chunk	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

This depends on another CL that changes test.dart. See: https://chromiumcodereview.appspot.com/9475038 for more details. https://chromiumcodereview.appspot.com/9478027/diff/1/lib/isolate/frog/isolateimpl.dart File ...

8 years, 9 months ago (2012-02-28 02:40:48 UTC) #1

eub

LGTM http://codereview.chromium.org/9478027/diff/4001/lib/isolate/frog/isolateimpl.dart File lib/isolate/frog/isolateimpl.dart (right): http://codereview.chromium.org/9478027/diff/4001/lib/isolate/frog/isolateimpl.dart#newcode612 lib/isolate/frog/isolateimpl.dart:612: if (!(new Uri.fromString(uri).isAbsolute())) { Can you comment why ...

8 years, 9 months ago (2012-02-28 21:13:42 UTC) #2

Siggi Cherem (dart-lang)

8 years, 9 months ago (2012-02-28 21:53:40 UTC) #3

thanks!

http://codereview.chromium.org/9478027/diff/4001/lib/isolate/frog/isolateimpl...
File lib/isolate/frog/isolateimpl.dart (right):

http://codereview.chromium.org/9478027/diff/4001/lib/isolate/frog/isolateimpl...
lib/isolate/frog/isolateimpl.dart:612: if (!(new
Uri.fromString(uri).isAbsolute())) {
On 2012/02/28 21:13:42, eub wrote:
> Can you comment why we're forcing the uri to be absolute?

Done.

http://codereview.chromium.org/9478027/diff/4001/tests/isolate/src/APIv2_spaw...
File tests/isolate/src/APIv2_spawnUriBrowserTest.dart (right):

http://codereview.chromium.org/9478027/diff/4001/tests/isolate/src/APIv2_spaw...
tests/isolate/src/APIv2_spawnUriBrowserTest.dart:12: #import('dart:isolate');
On 2012/02/28 21:13:42, eub wrote:
> (Why did I mix single and double quotes?)

Maybe the old tests had it also :)?

According to our style guide we should favor single quotes if possible. Fixed in
these files, will fix the others as I touch them in other CLs.

Expand Messages | Collapse Messages