test.dart: add support for compiling multiple scripts for a single test.

test.dart: add support for compiling multiple scripts for a single test.

Committed: https://code.google.com/p/dart/source/detail?r=4708

[Siggi Cherem (dart-lang), 2012-02-28 02:45:21]

I basically followed the first part of your suggestion: I added support for
compiling a list of files, not just 1 or 2. 

I also added a new comment option (similar to VMOptions and DartOptions) that is
used by the test script to figure out if there are more scripts to compile. This
preserves the current structure that each test is a single file.

I have an example that uses this in a separate CL. The test required some
additional changes/fixes so I decided to put it in a separate change. See
https://chromiumcodereview.appspot.com/9478027/


I didn't refactor the code to do the double dispatch since I don't feel too
familiar with this code to do that yet.

[Siggi Cherem (dart-lang), 2012-02-28 02:45:37]

+eub

[Bill Hesse, 2012-02-28 16:41:56]

This is really nice.  LGTM.

http://codereview.chromium.org/9475038/diff/1/tools/testing/dart/test_runner....
File tools/testing/dart/test_runner.dart (right):

http://codereview.chromium.org/9475038/diff/1/tools/testing/dart/test_runner....
tools/testing/dart/test_runner.dart:318: stderr.add('test.dart: Compilation step
finished\n');
Could we add currentStep to the messages in stderr and stdout?

http://codereview.chromium.org/9475038/diff/1/tools/testing/dart/test_suite.dart
File tools/testing/dart/test_suite.dart (right):

http://codereview.chromium.org/9475038/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:525: Expect.isTrue(end > 0);
Could we print a warning, and just return without adding a testCase, in this
case, rather than terminating the test script?

[Siggi Cherem (dart-lang), 2012-02-28 17:42:37]

Thanks Bill!

Submitting shortly.

http://codereview.chromium.org/9475038/diff/1/tools/testing/dart/test_runner....
File tools/testing/dart/test_runner.dart (right):

http://codereview.chromium.org/9475038/diff/1/tools/testing/dart/test_runner....
tools/testing/dart/test_runner.dart:318: stderr.add('test.dart: Compilation step
finished\n');
On 2012/02/28 16:41:56, Bill Hesse wrote:
> Could we add currentStep to the messages in stderr and stdout?

Done

http://codereview.chromium.org/9475038/diff/1/tools/testing/dart/test_suite.dart
File tools/testing/dart/test_suite.dart (right):

http://codereview.chromium.org/9475038/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:525: Expect.isTrue(end > 0);
On 2012/02/28 16:41:56, Bill Hesse wrote:
> Could we print a warning, and just return without adding a testCase, in this
> case, rather than terminating the test script?

Good point. Fixed.