Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 9474040: Improve exception handling: (Closed)

Created:
8 years, 10 months ago by ahe
Modified:
8 years, 9 months ago
Reviewers:
floitsch, ngeoffray, kasperl
CC:
reviews_dartlang.org, kasperl, Lasse Reichstein Nielsen, karlklose
Visibility:
Public.

Description

Improve exception handling: * Translate native JS exceptions to corresponding Dart objects. * Implement rethrow. Also handle abstract methods and final fields correctly. Finally, don't cancel compilation when seeing a continue statement, instead generate code that throws an exception. Committed: https://code.google.com/p/dart/source/detail?r=4701

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -83 lines) Patch
M dart/frog/leg/emitter.dart View 2 chunks +3 lines, -1 line 0 comments Download
M dart/frog/leg/lib/js_helper.dart View 1 1 chunk +42 lines, -0 lines 0 comments Download
M dart/frog/leg/ssa/builder.dart View 8 chunks +32 lines, -7 lines 0 comments Download
M dart/frog/leg/ssa/codegen.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M dart/frog/leg/ssa/nodes.dart View 1 chunk +2 lines, -1 line 0 comments Download
M dart/frog/leg/universe.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M dart/tests/co19/co19-leg.status View 15 chunks +4 lines, -57 lines 0 comments Download
M dart/tests/language/language-leg.status View 6 chunks +4 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
8 years, 10 months ago (2012-02-28 06:50:55 UTC) #1
kasperl
LGTM. https://chromiumcodereview.appspot.com/9474040/diff/1/dart/frog/leg/lib/js_helper.dart File dart/frog/leg/lib/js_helper.dart (right): https://chromiumcodereview.appspot.com/9474040/diff/1/dart/frog/leg/lib/js_helper.dart#newcode1246 dart/frog/leg/lib/js_helper.dart:1246: var type = JS('String', @'$0.type', ex); This (ex.type) ...
8 years, 9 months ago (2012-02-28 09:22:11 UTC) #2
ngeoffray
LGTM!
8 years, 9 months ago (2012-02-28 10:23:15 UTC) #3
ahe
8 years, 9 months ago (2012-02-28 16:25:52 UTC) #4
Hi Kasper and Nicolas,

Thank you for taking a look.

Cheers,
Peter

https://chromiumcodereview.appspot.com/9474040/diff/1/dart/frog/leg/lib/js_he...
File dart/frog/leg/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/9474040/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:1246: var type = JS('String', @'$0.type', ex);
On 2012/02/28 09:22:11, kasperl wrote:
> This (ex.type) is very Chrome specific code. Maybe add a comment here or even
> factor this out into a helper with a name that makes it obvious that this only
> works on Chrome/V8.

Done.

Powered by Google App Engine
This is Rietveld 408576698