Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: dart/frog/leg/emitter.dart

Issue 9474040: Improve exception handling: (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Add TODO Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/frog/leg/lib/js_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/emitter.dart
diff --git a/dart/frog/leg/emitter.dart b/dart/frog/leg/emitter.dart
index a536e473d163ebc1c00209588adba73c91b20612..fa4c17e003039a67ec0031d5f814e61a1c41c834 100644
--- a/dart/frog/leg/emitter.dart
+++ b/dart/frog/leg/emitter.dart
@@ -170,6 +170,7 @@ function(child, parent) {
|| member.kind === ElementKind.GENERATIVE_CONSTRUCTOR_BODY
|| member.kind === ElementKind.GETTER
|| member.kind === ElementKind.SETTER) {
+ if (member.modifiers !== null && member.modifiers.isAbstract()) return;
String codeBlock = compiler.universe.generatedCode[member];
if (codeBlock == null) return;
buffer.add('$prototype.${namer.getName(member)} = $codeBlock;\n');
@@ -185,7 +186,8 @@ function(child, parent) {
} else if (member.kind === ElementKind.FIELD) {
// TODO(ngeoffray): Have another class generate the code for the
// fields.
- if (compiler.universe.invokedSetters.contains(member.name)) {
+ if ((member.modifiers === null || !member.modifiers.isFinal()) &&
+ compiler.universe.invokedSetters.contains(member.name)) {
String setterName = namer.setterName(member.name);
buffer.add('$prototype.$setterName = function(v){\n' +
' this.${namer.getName(member)} = v;\n};\n');
« no previous file with comments | « no previous file | dart/frog/leg/lib/js_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698