Implement automatically generated constructors for frog and dartium dart:html

Implement automatically generated constructors for frog dart:html

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=5066

[sra1, 2012-02-24 05:49:09]

I'm having a little difficulty with the test - does frog pick up
client/html/frog/html_frog.dart?

[Jacob, 2012-02-25 03:50:03]

lgtm

https://chromiumcodereview.appspot.com/9464002/diff/2002/client/dom/scripts/s...
File client/dom/scripts/systemhtml.py (left):

https://chromiumcodereview.appspot.com/9464002/diff/2002/client/dom/scripts/s...
client/dom/scripts/systemhtml.py:685: if setter:
can you revert this part?

[sra1, 2012-03-07 01:28:48]

PTAL

[Jacob, 2012-03-07 03:51:27]

Loog good overall. A few minor comments.

https://chromiumcodereview.appspot.com/9464002/diff/9004/client/dom/scripts/s...
File client/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/9464002/diff/9004/client/dom/scripts/s...
client/dom/scripts/systemhtml.py:774: NAMEDCONSTRUCTOR=constructor_info.name or
interface_name,
out of curiosity is there a reason you use NAMEDCONSTRUCTOR instead of
NAMED_CONSTRUCTOR in the templates here and elsewhere?  I believe the template
processor handles both cases and using _ between words would be more consistent
with python and make the code easier to read with so many multiple word names.

https://chromiumcodereview.appspot.com/9464002/diff/9004/client/dom/src/_XMLH...
File client/dom/src/_XMLHttpRequestUtils.dart (right):

https://chromiumcodereview.appspot.com/9464002/diff/9004/client/dom/src/_XMLH...
client/dom/src/_XMLHttpRequestUtils.dart:5: class _XMLHttpRequestUtils {
why is this dart:html specific code in client/dom/src ?

https://chromiumcodereview.appspot.com/9464002/diff/9004/client/dom/templates...
File client/dom/templates/html/frog/factoryprovider_AudioElement.darttemplate
(right):

https://chromiumcodereview.appspot.com/9464002/diff/9004/client/dom/templates...
client/dom/templates/html/frog/factoryprovider_AudioElement.darttemplate:7: '''
is there a reason this odd formatting is used for the native call?

https://chromiumcodereview.appspot.com/9464002/diff/9004/client/tests/client/...
File client/tests/client/html/AudioElementTest.dart (right):

https://chromiumcodereview.appspot.com/9464002/diff/9004/client/tests/client/...
client/tests/client/html/AudioElementTest.dart:10: var audio = new
AudioElement();   // would be new Audio() in JS
i'd remove the 
// would be new Audio() in JS comment.

[sra1, 2012-03-07 05:03:11]

https://chromiumcodereview.appspot.com/9464002/diff/9004/client/dom/scripts/s...
File client/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/9464002/diff/9004/client/dom/scripts/s...
client/dom/scripts/systemhtml.py:774: NAMEDCONSTRUCTOR=constructor_info.name or
interface_name,
On 2012/03/07 03:51:27, Jacob wrote:
> out of curiosity is there a reason you use NAMEDCONSTRUCTOR instead of
> NAMED_CONSTRUCTOR in the templates here and elsewhere?  I believe the template
> processor handles both cases and using _ between words would be more
consistent
> with python and make the code easier to read with so many multiple word names.

Done.

https://chromiumcodereview.appspot.com/9464002/diff/9004/client/dom/src/_XMLH...
File client/dom/src/_XMLHttpRequestUtils.dart (right):

https://chromiumcodereview.appspot.com/9464002/diff/9004/client/dom/src/_XMLH...
client/dom/src/_XMLHttpRequestUtils.dart:5: class _XMLHttpRequestUtils {
On 2012/03/07 03:51:27, Jacob wrote:
> why is this dart:html specific code in client/dom/src ?

I will make dart:dom use it too under a separate CL.

https://chromiumcodereview.appspot.com/9464002/diff/9004/client/dom/templates...
File client/dom/templates/html/frog/factoryprovider_AudioElement.darttemplate
(right):

https://chromiumcodereview.appspot.com/9464002/diff/9004/client/dom/templates...
client/dom/templates/html/frog/factoryprovider_AudioElement.darttemplate:7: '''
On 2012/03/07 03:51:27, Jacob wrote:
> is there a reason this odd formatting is used for the native call?

Any indentation in the multiline string gets copied needlessly to the generated
JS.
I'll indent it all the same, since it is more readable.

https://chromiumcodereview.appspot.com/9464002/diff/9004/client/tests/client/...
File client/tests/client/html/AudioElementTest.dart (right):

https://chromiumcodereview.appspot.com/9464002/diff/9004/client/tests/client/...
client/tests/client/html/AudioElementTest.dart:10: var audio = new
AudioElement();   // would be new Audio() in JS
On 2012/03/07 03:51:27, Jacob wrote:
> i'd remove the 
> // would be new Audio() in JS comment.

Done.