Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: client/html/src/frog_FactoryProviders.dart

Issue 9464002: Implement automatically generated constructors for frog and dartium dart:html (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address code review comments Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/html/src/dartium_FactoryProviders.dart ('k') | client/tests/client/html/AudioElementTest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/html/src/frog_FactoryProviders.dart
diff --git a/client/html/src/frog_FactoryProviders.dart b/client/html/src/frog_FactoryProviders.dart
index d2d6d2e8cc7b09c5a2e7ade9aa340bc678aa068d..1f01ab1fb5a23191e0e0e630abd69c41876bc9bd 100644
--- a/client/html/src/frog_FactoryProviders.dart
+++ b/client/html/src/frog_FactoryProviders.dart
@@ -10,16 +10,6 @@ class _AudioContextFactoryProvider {
''';
}
-class _DOMParserFactoryProvider {
-
- factory DOMParser() native 'return new DOMParser();';
-}
-
-class _FileReaderFactoryProvider {
-
- factory FileReader() native 'return new FileReader();';
-}
-
class _TypedArrayFactoryProvider {
factory Float32Array(int length) => _F32(length);
@@ -71,44 +61,7 @@ class _TypedArrayFactoryProvider {
static ensureNative(List list) => list; // TODO: make sure.
}
-class _CSSMatrixFactoryProvider {
-
- factory CSSMatrix([String spec = '']) native
- 'return new WebKitCSSMatrix(spec);';
-}
-
class _PointFactoryProvider {
factory Point(num x, num y) native 'return new WebKitPoint(x, y);';
}
-
-class _WebSocketFactoryProvider {
-
- factory WebSocket(String url) native 'return new WebSocket(url);';
-}
-
-class _XMLHttpRequestFactoryProvider {
- factory XMLHttpRequest() native 'return new XMLHttpRequest();';
-
- factory XMLHttpRequest.getTEMPNAME(String url,
- onSuccess(XMLHttpRequest request)) {
- final request = new XMLHttpRequest();
- request.open('GET', url, true);
-
- // TODO(terry): Validate after client login added if necessary to forward
- // cookies to server.
- request.withCredentials = true;
-
- // Status 0 is for local XHR request.
- request.on.readyStateChange.add((e) {
- if (request.readyState == XMLHttpRequest.DONE &&
- (request.status == 200 || request.status == 0)) {
- onSuccess(request);
- }
- });
-
- request.send();
-
- return request;
- }
-}
« no previous file with comments | « client/html/src/dartium_FactoryProviders.dart ('k') | client/tests/client/html/AudioElementTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698