Issue 9447028: When tracing type checks in runtime, also print the method where the type check occured.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9447028: When tracing type checks in runtime, also print the method where the type check occured. (Closed)

Created:
8 years, 10 months ago by srdjan

Modified:
8 years, 10 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, ahe

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

When tracing type checks in runtime, also print the method where the type check occured. Committed: https://code.google.com/p/dart/source/detail?r=4551

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	runtime/lib/error.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	runtime/vm/code_generator.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

regis

LGTM How about adding this code to vm/code_generator.cc:275 as well?

8 years, 10 months ago (2012-02-23 19:16:37 UTC) #4

srdjan

8 years, 10 months ago (2012-02-23 19:51:24 UTC) #5

On 2012/02/23 19:16:37, regis wrote:
> LGTM
> 
> How about adding this code to vm/code_generator.cc:275 as well?

Done.