Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: runtime/vm/code_generator.cc

Issue 9447028: When tracing type checks in runtime, also print the method where the type check occured. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/lib/error.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/code_generator.h" 5 #include "vm/code_generator.h"
6 6
7 #include "vm/code_index_table.h" 7 #include "vm/code_index_table.h"
8 #include "vm/code_patcher.h" 8 #include "vm/code_patcher.h"
9 #include "vm/compiler.h" 9 #include "vm/compiler.h"
10 #include "vm/dart_api_impl.h" 10 #include "vm/dart_api_impl.h"
(...skipping 324 matching lines...) Expand 10 before | Expand all | Expand 10 after
335 } else { 335 } else {
336 // Instantiate type before printing. 336 // Instantiate type before printing.
337 const AbstractType& instantiated_type = 337 const AbstractType& instantiated_type =
338 AbstractType::Handle(type.InstantiateFrom(type_instantiator)); 338 AbstractType::Handle(type.InstantiateFrom(type_instantiator));
339 OS::Print("InstanceOf: '%s' %s '%s' instantiated from '%s'.\n", 339 OS::Print("InstanceOf: '%s' %s '%s' instantiated from '%s'.\n",
340 String::Handle(instance_type.Name()).ToCString(), 340 String::Handle(instance_type.Name()).ToCString(),
341 (result.raw() == Bool::True()) ? "is" : "is !", 341 (result.raw() == Bool::True()) ? "is" : "is !",
342 String::Handle(instantiated_type.Name()).ToCString(), 342 String::Handle(instantiated_type.Name()).ToCString(),
343 String::Handle(type.Name()).ToCString()); 343 String::Handle(type.Name()).ToCString());
344 } 344 }
345 DartFrameIterator iterator;
346 DartFrame* caller_frame = iterator.NextFrame();
347 ASSERT(caller_frame != NULL);
348 const Function& function = Function::Handle(
349 caller_frame->LookupDartFunction());
350 OS::Print(" -> Function %s\n", function.ToFullyQualifiedCString());
345 } 351 }
346 arguments.SetReturn(result); 352 arguments.SetReturn(result);
347 } 353 }
348 354
349 355
350 DEFINE_RUNTIME_ENTRY(Throw, 1) { 356 DEFINE_RUNTIME_ENTRY(Throw, 1) {
351 ASSERT(arguments.Count() == kThrowRuntimeEntry.argument_count()); 357 ASSERT(arguments.Count() == kThrowRuntimeEntry.argument_count());
352 const Instance& exception = Instance::CheckedHandle(arguments.At(0)); 358 const Instance& exception = Instance::CheckedHandle(arguments.At(0));
353 Exceptions::Throw(exception); 359 Exceptions::Throw(exception);
354 } 360 }
(...skipping 763 matching lines...) Expand 10 before | Expand all | Expand 10 after
1118 } 1124 }
1119 } 1125 }
1120 } 1126 }
1121 // The cache is null terminated, therefore the loop above should never 1127 // The cache is null terminated, therefore the loop above should never
1122 // terminate by itself. 1128 // terminate by itself.
1123 UNREACHABLE(); 1129 UNREACHABLE();
1124 return Code::null(); 1130 return Code::null();
1125 } 1131 }
1126 1132
1127 } // namespace dart 1133 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/lib/error.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698