Added LongJump for bailout. When trying to fix all crashes, CHECK_ALIVE did not scale well as bail…

Added LongJump for bailout. When trying to fix all crashes, CHECK_ALIVE did  not scale well as bailing out mechanism.
Implemented UnaryOpNode. Fix crashes.
(this CL also includes the patches from https://chromiumcodereview.appspot.com/9429056/, will remove them once syncing with submitted 9429056)
Committed: https://code.google.com/p/dart/source/detail?r=4541

[Kevin Millikin (Google), 2012-02-23 09:31:43]

Thanks, that's much nicer.  LGTM.

https://chromiumcodereview.appspot.com/9443002/diff/4001/runtime/vm/flow_grap...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/9443002/diff/4001/runtime/vm/flow_grap...
runtime/vm/flow_graph_builder.cc:341: return new InstanceCallComp(node.Name(),
argument);
We might want to make the InstanceCallComp (and other kinds of call) constructor
take varargs, or else have overloaded versions for common argument counts, and
make the array embedded in the instruction rather than indirect, and get rid of
the allocation and calls to Add at every call site.

What do you think?

[srdjan, 2012-02-23 16:06:12]

https://chromiumcodereview.appspot.com/9443002/diff/4001/runtime/vm/flow_grap...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/9443002/diff/4001/runtime/vm/flow_grap...
runtime/vm/flow_graph_builder.cc:341: return new InstanceCallComp(node.Name(),
argument);
On 2012/02/23 09:31:43, kmillikin wrote:
> We might want to make the InstanceCallComp (and other kinds of call)
constructor
> take varargs, or else have overloaded versions for common argument counts, and
> make the array embedded in the instruction rather than indirect, and get rid
of
> the allocation and calls to Add at every call site.
> 
> What do you think?

I do not think that cost of allocating ZoneGrowableArray will be relevant. We do
something similar in the old code generator and the cost of the code generator
has not shown up on the profile. I am also not in favor of using varargs but in
some very rare cases.