Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1141)

Unified Diff: runtime/vm/flow_graph_builder.h

Issue 9443002: Added LongJump for bailout. When trying to fix all crashes, CHECK_ALIVE did not scale well as bail… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.h
===================================================================
--- runtime/vm/flow_graph_builder.h (revision 4539)
+++ runtime/vm/flow_graph_builder.h (working copy)
@@ -20,25 +20,17 @@
public:
explicit FlowGraphBuilder(const ParsedFunction& parsed_function)
: parsed_function_(parsed_function),
- bailout_reason_(NULL),
postorder_block_entries_() { }
void BuildGraph();
const ParsedFunction& parsed_function() const { return parsed_function_; }
- bool HasBailedOut() const { return bailout_reason_ != NULL; }
- void Bailout(const char* reason) {
- // Cannot give a NULL reason because we use it to detect bailout.
- ASSERT(!HasBailedOut() && (reason != NULL));
- bailout_reason_ = reason;
- }
- void TraceBailout() const;
+ void Bailout(const char* reason);
void PrintGraph() const;
private:
const ParsedFunction& parsed_function_;
- const char* bailout_reason_;
GrowableArray<Instruction*> postorder_block_entries_;
};
@@ -97,6 +89,7 @@
// Implement the core part of the translation of expression node types.
AssertAssignableComp* TranslateAssignable(const AssignableNode& node);
InstanceCallComp* TranslateBinaryOp(const BinaryOpNode& node);
+ InstanceCallComp* TranslateUnaryOp(const UnaryOpNode& node);
InstanceCallComp* TranslateComparison(const ComparisonNode& node);
StoreLocalComp* TranslateStoreLocal(const StoreLocalNode& node);
StaticCallComp* TranslateStaticCall(const StaticCallNode& node);
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698