Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 9442015: Since dartc has no backend anymore, a runtime error in a multitest does *not* make it a negative te… (Closed)

Created:
8 years, 10 months ago by ngeoffray
Modified:
8 years, 10 months ago
Reviewers:
ahe, Bill Hesse, zundel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Sicne dartc has no backend anymore, a runtime error in a multitest does *not* make it a negative test. Committed: https://code.google.com/p/dart/source/detail?r=4531

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M dart/tests/language/language.status View 1 chunk +0 lines, -2 lines 0 comments Download
M dart/tools/testing/dart/multitest.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M dart/tools/testing/dart/test_suite.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ngeoffray
8 years, 10 months ago (2012-02-23 10:16:39 UTC) #1
zundel
lgtm in light of recent discussion, testing the exception type and using a 'string' as ...
8 years, 10 months ago (2012-02-23 13:00:24 UTC) #2
ahe
On 2012/02/23 13:00:24, zundel wrote: > lgtm > > in light of recent discussion, testing ...
8 years, 10 months ago (2012-02-23 13:30:30 UTC) #3
ngeoffray
8 years, 10 months ago (2012-02-23 13:56:12 UTC) #4
Thanks both of you for having taken a look.

Powered by Google App Engine
This is Rietveld 408576698