Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: dart/tools/testing/dart/multitest.dart

Issue 9442015: Since dartc has no backend anymore, a runtime error in a multitest does *not* make it a negative te… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tests/language/language.status ('k') | dart/tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/multitest.dart
===================================================================
--- dart/tools/testing/dart/multitest.dart (revision 4517)
+++ dart/tools/testing/dart/multitest.dart (working copy)
@@ -70,7 +70,7 @@
Set<String> validMultitestOutcomes = new Set<String>.from(
['compile-time error', 'runtime error',
'static type error', 'dynamic type error', '']);
-
+
List<String> testTemplate = new List<String>();
testTemplate.add('// Test created from multitest named $filename.');
// Create the set of multitests, which will have a new test added each
@@ -107,7 +107,7 @@
// Add the template, with no multitest lines, as a test with key 'none'.
testsAsLines['none'] = testTemplate;
outcomes['none'] = '';
-
+
// Copy all the tests into the output map tests, as multiline strings.
for (String key in testsAsLines.getKeys()) {
tests[key] =
@@ -117,6 +117,7 @@
void DoMultitest(String filename,
+ String component,
String outputDir,
String testDir,
Function doTest(String filename,
@@ -145,8 +146,8 @@
openedFile.closeSync();
var outcome = outcomes[key];
bool enableFatalTypeErrors = outcome.contains('static type error');
- bool isNegative = (outcome.contains('compile-time error') ||
- outcome.contains('runtime error'));
+ bool isNegative = (outcome.contains('compile-time error')
+ || (outcome.contains('runtime error') && (component != 'dartc')));
bool isNegativeIfChecked = outcome.contains('dynamic type error');
doTest(filename,
isNegative,
« no previous file with comments | « dart/tests/language/language.status ('k') | dart/tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698