Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 9432024: Do not rename idl types to dart types at top level - this info is needed for native bindings genera… (Closed)

Created:
8 years, 10 months ago by podivilov
Modified:
8 years, 10 months ago
Reviewers:
sra, sra1, Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do not rename idl types to dart types at top level - this info is needed for native bindings generation. R=sra@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=4610

Patch Set 1 #

Patch Set 2 : Update html frog system. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -107 lines) Patch
M client/dom/scripts/dartdomgenerator.py View 1 chunk +0 lines, -4 lines 0 comments Download
M client/dom/scripts/dartgenerator.py View 1 1 chunk +0 lines, -34 lines 0 comments Download
M client/dom/scripts/dartgenerator_test.py View 1 chunk +0 lines, -1 line 0 comments Download
M client/dom/scripts/generator.py View 1 10 chunks +53 lines, -31 lines 0 comments Download
M client/dom/scripts/systemfrog.py View 1 6 chunks +7 lines, -7 lines 0 comments Download
M client/dom/scripts/systemhtml.py View 1 5 chunks +7 lines, -7 lines 0 comments Download
M client/dom/scripts/systeminterface.py View 1 3 chunks +6 lines, -6 lines 0 comments Download
M client/dom/scripts/systemnative.py View 5 chunks +7 lines, -4 lines 0 comments Download
M client/dom/scripts/systemwrapping.py View 6 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
podivilov
8 years, 10 months ago (2012-02-22 13:48:36 UTC) #1
sra1
Adding Jacob as reviewer and this change affects dart:html. Jacob will generate instructions for testing ...
8 years, 10 months ago (2012-02-22 21:19:36 UTC) #2
Jacob
Instructions to test that dart:html is not impacted: from client/dom/scripts ./dartdomgenerator.py --systems=htmlfrog check that client/html/frog/html_frog.dart ...
8 years, 10 months ago (2012-02-22 21:43:49 UTC) #3
podivilov
On 2012/02/22 21:43:49, Jacob wrote: > Instructions to test that dart:html is not impacted: > ...
8 years, 10 months ago (2012-02-24 15:45:16 UTC) #4
sra1
8 years, 10 months ago (2012-02-25 22:47:01 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698