Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: client/dom/scripts/dartgenerator.py

Issue 9432024: Do not rename idl types to dart types at top level - this info is needed for native bindings genera… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update html frog system. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/dom/scripts/dartdomgenerator.py ('k') | client/dom/scripts/dartgenerator_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/dom/scripts/dartgenerator.py
diff --git a/client/dom/scripts/dartgenerator.py b/client/dom/scripts/dartgenerator.py
index 0b966129afc6f3269ba46593142d64a6779a895b..742fa21a379d03c0f8625d38a9d2e601f640ac03 100755
--- a/client/dom/scripts/dartgenerator.py
+++ b/client/dom/scripts/dartgenerator.py
@@ -142,40 +142,6 @@ class DartGenerator(object):
interface.operations = filter(IsIdentified, interface.operations)
interface.parents = filter(IsIdentified, interface.parents)
- def ConvertToDartTypes(self, database):
- """Converts all IDL types to Dart primitives or qualified types"""
-
- def ConvertType(interface, type_name):
- """Helper method for converting a type name to the proper
- Dart name"""
- if IsPrimitiveType(type_name):
- return ConvertPrimitiveType(type_name)
-
- if self._IsDartType(type_name):
- # This is for when dart qualified names are explicitly
- # defined in the IDLs. Just let them be.
- return type_name
-
- dart_template_match = self._dart_templates_re.match(type_name)
- if dart_template_match:
- # Dart templates
- parent_type_name = type_name[0 : dart_template_match.start(1) - 1]
- sub_type_name = dart_template_match.group(1)
- return '%s<%s>' % (ConvertType(interface, parent_type_name),
- ConvertType(interface, sub_type_name))
-
- return self._StripModules(type_name)
-
- for interface in database.GetInterfaces():
- for idl_type in interface.all(idlnode.IDLType):
- original_type_name = idl_type.id
- idl_type.id = ConvertType(interface, idl_type.id)
- # FIXME: remember original idl types that are needed by native
- # generator. We should migrate other generators to idl registry and
- # remove this hack.
- if original_type_name != idl_type.id:
- original_idl_types[idl_type] = original_type_name
-
def FilterInterfaces(self, database,
and_annotations=[],
or_annotations=[],
« no previous file with comments | « client/dom/scripts/dartdomgenerator.py ('k') | client/dom/scripts/dartgenerator_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698