Implement operator-is for interfaces' supertypes and String's supertypes. Also, improve stack trace…

Implement operator-is for interfaces' supertypes and String's supertypes. Also, improve stack traces.

Committed: https://code.google.com/p/dart/source/detail?r=4544

[ngeoffray, 2012-02-22 11:12:35]

LGTM!

https://chromiumcodereview.appspot.com/9429047/diff/1/dart/frog/leg/lib/js_he...
File dart/frog/leg/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/9429047/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:1181: return ex;
Remove this line.

https://chromiumcodereview.appspot.com/9429047/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:1182: if (ex === null) return ex;
You could change that to:
if (JS('bool', @'typeof $0 !== "object"', ex)) return ex;

https://chromiumcodereview.appspot.com/9429047/diff/1/dart/frog/leg/ssa/codeg...
File dart/frog/leg/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/9429047/diff/1/dart/frog/leg/ssa/codeg...
dart/frog/leg/ssa/codegen.dart:687: compiler.registerStaticUse(toStringHelper);
Please add a comment that you're adding toString because the JS engine will call
toString on an uncaught exception, which will call this builtin toString.

https://chromiumcodereview.appspot.com/9429047/diff/1/dart/frog/leg/ssa/codeg...
dart/frog/leg/ssa/codegen.dart:904: if (element == coreLibrary.find(const
SourceString('Pattern'))) {
Please merge the conditions into one if. Also add a comment why you need to do
this.

[karlklose, 2012-02-22 13:20:45]

LGTM.

[ahe, 2012-02-22 21:51:24]

Hi Nicolas and Karl,

Thank you for taking a look, please take another :-)

I added a test and implemented String.charCodes(), as I couldn't figure out how
to test it otherwise.

Cheers,
Peter

https://chromiumcodereview.appspot.com/9429047/diff/1/dart/frog/leg/lib/js_he...
File dart/frog/leg/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/9429047/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:1181: return ex;
On 2012/02/22 11:12:36, ngeoffray wrote:
> Remove this line.

Done.

https://chromiumcodereview.appspot.com/9429047/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:1182: if (ex === null) return ex;
On 2012/02/22 11:12:36, ngeoffray wrote:
> You could change that to:
> if (JS('bool', @'typeof $0 !== "object"', ex)) return ex;

Great idea!

https://chromiumcodereview.appspot.com/9429047/diff/1/dart/frog/leg/ssa/codeg...
File dart/frog/leg/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/9429047/diff/1/dart/frog/leg/ssa/codeg...
dart/frog/leg/ssa/codegen.dart:687: compiler.registerStaticUse(toStringHelper);
On 2012/02/22 11:12:36, ngeoffray wrote:
> Please add a comment that you're adding toString because the JS engine will
call
> toString on an uncaught exception, which will call this builtin toString.

Done.

https://chromiumcodereview.appspot.com/9429047/diff/1/dart/frog/leg/ssa/codeg...
dart/frog/leg/ssa/codegen.dart:904: if (element == coreLibrary.find(const
SourceString('Pattern'))) {
On 2012/02/22 11:12:36, ngeoffray wrote:
> Please merge the conditions into one if. Also add a comment why you need to do
> this.

Done.

[ngeoffray, 2012-02-23 08:20:59]

LGTM