Implement operator-is for interfaces' supertypes and String's supertypes. Also, improve stack trace…

dart/frog/leg/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   SsaCodeGeneratorTask(Compiler compiler) : super(compiler);
   String get name() => 'SSA code generator';
 
   String generate(WorkItem work, HGraph graph) {
     return measure(() {
@@ skipping 664 matching lines @@
       use(node.inputs[0], JSPrecedence.EXPRESSION_PRECEDENCE);
       buffer.add(';\n');
     }
   }
 
   visitThis(HThis node) {
     buffer.add('this');
   }
 
   visitThrow(HThrow node) {
-    buffer.add('throw ');
-    use(node.inputs[0], JSPrecedence.EXPRESSION_PRECEDENCE);
+    Element toStringHelper =
+      compiler.findHelper(new SourceString(@'builtin$toString$0'));
+    compiler.registerStaticUse(toStringHelper);

[ngeoffray, 2012/02/22 11:12:36]

Please add a comment that you're adding toString because the JS engine will call
toString on an uncaught exception, which will call this builtin toString.

[ahe, 2012/02/22 21:51:24]

Done.

+    generateThrowWithHelper('captureStackTrace', node.inputs[0]);
     buffer.add(';\n');
   }
 
   visitBoundsCheck(HBoundsCheck node) {
     buffer.add('if (');
     use(node.index, JSPrecedence.RELATIONAL_PRECEDENCE);
     buffer.add(' < 0 || ');
     use(node.index, JSPrecedence.RELATIONAL_PRECEDENCE);
     buffer.add(' >= ');
     use(node.length, JSPrecedence.SHIFT_PRECEDENCE);
     buffer.add(") ");
-    generateFail('ioore', node.index);
+    generateThrowWithHelper('ioore', node.index);
   }
 
   visitIntegerCheck(HIntegerCheck node) {
     buffer.add('if (');
     use(node.value, JSPrecedence.EQUALITY_PRECEDENCE);
     buffer.add(' !== (');
     use(node.value, JSPrecedence.BITWISE_OR_PRECEDENCE);
     buffer.add(" | 0)) ");
-    generateFail('iae', node.value);
+    generateThrowWithHelper('iae', node.value);
   }
 
-  void generateFail(String helperName, HInstruction argument) {
+  void generateThrowWithHelper(String helperName, HInstruction argument) {
     Element helper = compiler.findHelper(new SourceString(helperName));
     compiler.registerStaticUse(helper);
     buffer.add('throw ');
     beginExpression(JSPrecedence.EXPRESSION_PRECEDENCE);
     beginExpression(JSPrecedence.CALL_PRECEDENCE);
     buffer.add(compiler.namer.isolateAccess(helper));
     visitArguments([null, argument]);
     endExpression(JSPrecedence.CALL_PRECEDENCE);
     endExpression(JSPrecedence.EXPRESSION_PRECEDENCE);
   }
@@ skipping 163 matching lines @@
     } else if (element == coreLibrary.find(const SourceString('bool'))) {
       checkBool(input, '===');
     } else if (element == coreLibrary.find(const SourceString('int'))) {
       beginExpression(JSPrecedence.LOGICAL_AND_PRECEDENCE);
       checkNum(input, '===');
       buffer.add(' && ');
       checkInt(input, '===');
       endExpression(JSPrecedence.LOGICAL_AND_PRECEDENCE);
     } else {
       beginExpression(JSPrecedence.LOGICAL_AND_PRECEDENCE);
+      if (element == coreLibrary.find(const SourceString('Comparable'))) {
+        checkString(input, '===');
+        buffer.add(' || ');
+      }
+      if (element == coreLibrary.find(const SourceString('Hashable'))) {
+        checkString(input, '===');
+        buffer.add(' || ');
+      }
+      if (element == coreLibrary.find(const SourceString('Pattern'))) {

[ngeoffray, 2012/02/22 11:12:36]

Please merge the conditions into one if. Also add a comment why you need to do
this.

[ahe, 2012/02/22 21:51:24]

Done.

+        checkString(input, '===');
+        buffer.add(' || ');
+      }
       checkObject(input, '===');
       buffer.add(' && ');
       int precedence = JSPrecedence.PREFIX_PRECEDENCE;
       bool endParen = false;
       if (element == coreLibrary.find(const SourceString('List'))) {
         buffer.add("(");
         endParen = true;
         beginExpression(JSPrecedence.LOGICAL_AND_PRECEDENCE);
         checkObject(input, '===');
         buffer.add(' && ');
@@ skipping 358 matching lines @@
       startBailoutSwitch();
     }
   }
 
   void endElse(HIf node) {
     if (node.elseBlock.hasBailouts()) {
       endBailoutSwitch();
     }
   }
 }