Implement most of String API.

Implement most of String API.

Committed: https://code.google.com/p/dart/source/detail?r=4434

[kasperl, 2012-02-20 10:44:50]

LGTM.

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
File dart/frog/leg/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:434: return (a === b) ? 0 : JS('bool', @'$0 <
$1', a, b) ? -1 : 1;
Shouldn't this be (a == b)?

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:884: if (from is !String) throw new
IllegalArgumentException(from);
Duplicate line. Did you want to check to too?

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:914: return other === JS('String',
@'$0.substring(0, $1)', receiver, length);
== rather than ===

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:939: substringUnchecked(receiver, startIndex,
endIndex)
You're using rawXxx for some methods and xxxUnchecked for others?

[ahe, 2012-02-20 16:31:58]

Hi Kasper,

Thank you for taking a look. I'll send a new CL with the changes.

Cheers,
Peter

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
File dart/frog/leg/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:434: return (a === b) ? 0 : JS('bool', @'$0 <
$1', a, b) ? -1 : 1;
On 2012/02/20 10:44:51, kasperl wrote:
> Shouldn't this be (a == b)?

Not sure. Perhaps I should use JS('bool', '$0 == $1', a, b) instead. This way it
is clearer this is an "optimization".

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:884: if (from is !String) throw new
IllegalArgumentException(from);
On 2012/02/20 10:44:51, kasperl wrote:
> Duplicate line. Did you want to check to too?

Done.

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:914: return other === JS('String',
@'$0.substring(0, $1)', receiver, length);
On 2012/02/20 10:44:51, kasperl wrote:
> == rather than ===

Using JS.

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:939: substringUnchecked(receiver, startIndex,
endIndex)
On 2012/02/20 10:44:51, kasperl wrote:
> You're using rawXxx for some methods and xxxUnchecked for others?

Done.

[ngeoffray, 2012-02-21 09:45:37]

I understand this CL fixes a few tests, and that's good! But I'm not sure about
all the details.

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
File dart/frog/leg/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:204: if (index is !num) throw new
IllegalArgumentException(index);
Why not checkNum?

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:205: if (index.truncate() !== index) throw new
IllegalArgumentException(index);
What's this about?

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:317: checkNull(receiver);
No need for check null

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:319: if (index is !num) throw new
IllegalArgumentException(index);
Why not checkNum?

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:402: if (i is !int) throw new
IllegalArgumentException(i);
Why not checkInt?

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:433: if (b is !String) throw new
IllegalArgumentException(b);
checkString?

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:514: checkNull(element);
No need for check null

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:515: if (start is !int) throw new
IllegalArgumentException(start);
checkInt, checkString?

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:581: checkNull(element);
No need.

https://chromiumcodereview.appspot.com/9423034/diff/1/dart/frog/leg/lib/js_he...
dart/frog/leg/lib/js_helper.dart:593: checkNull(element);
No need.