Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: dart/frog/leg/lib/mockimpl.dart

Issue 9423034: Implement most of String API. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« dart/frog/leg/lib/js_helper.dart ('K') | « dart/frog/leg/lib/js_helper.dart ('k') | dart/tests/co19/co19-leg.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/lib/mockimpl.dart
diff --git a/dart/frog/leg/lib/mockimpl.dart b/dart/frog/leg/lib/mockimpl.dart
index 1a8e47e852a7149f7e2f55ad685e2852950d8354..fe65b9bda9798ceaec7e80905aaaba75aa31d38e 100644
--- a/dart/frog/leg/lib/mockimpl.dart
+++ b/dart/frog/leg/lib/mockimpl.dart
@@ -34,6 +34,7 @@ class StringBase {
static String createFromCharCodes(List<int> charCodes) {
checkNull(charCodes);
if (!isJSArray(charCodes)) {
+ if (charCodes is !List) throw new IllegalArgumentException(charCodes);
charCodes = new List.from(charCodes);
}
return Primitives.stringFromCharCodes(charCodes);
« dart/frog/leg/lib/js_helper.dart ('K') | « dart/frog/leg/lib/js_helper.dart ('k') | dart/tests/co19/co19-leg.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698