Issue 9380006: Support is!.

Issue 9380006: Support is!. (Closed)

Created:
8 years, 10 months ago by ngeoffray

Modified:
8 years, 10 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, kasperl, ahe, karlklose, Lasse Reichstein Nielsen

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Support is!. Committed: https://code.google.com/p/dart/source/detail?r=4224

Patch Set 3 : #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -7 lines)			Patch
M	dart/frog/leg/resolver.dart	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download
M	dart/frog/leg/scanner/listener.dart	View	1 2	1 chunk	+8 lines, -4 lines	0 comments	Download
M	dart/frog/leg/ssa/builder.dart	View	1 2	1 chunk	+15 lines, -1 line	0 comments	Download
M	dart/frog/leg/ssa/codegen.dart	View	1 2	3 chunks	+4 lines, -0 lines	0 comments	Download
M	dart/tests/language/language-leg.status	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://chromiumcodereview.appspot.com/9380006/diff/1/dart/frog/leg/scanner/listener.dart File dart/frog/leg/scanner/listener.dart (right): https://chromiumcodereview.appspot.com/9380006/diff/1/dart/frog/leg/scanner/listener.dart#newcode1258 dart/frog/leg/scanner/listener.dart:1258: NodeList arguments = new NodeList.singleton(type); remove line.

8 years, 10 months ago (2012-02-10 15:09:33 UTC) #2

ngeoffray

https://chromiumcodereview.appspot.com/9380006/diff/1/dart/frog/leg/scanner/listener.dart File dart/frog/leg/scanner/listener.dart (right): https://chromiumcodereview.appspot.com/9380006/diff/1/dart/frog/leg/scanner/listener.dart#newcode1258 dart/frog/leg/scanner/listener.dart:1258: NodeList arguments = new NodeList.singleton(type); On 2012/02/10 15:09:33, floitsch ...

8 years, 10 months ago (2012-02-10 15:11:43 UTC) #3

ahe

DBC. I'm not sure exactly what we should do to simplify this. I'm pointing out ...

8 years, 10 months ago (2012-02-13 09:59:56 UTC) #4

ngeoffray

8 years, 10 months ago (2012-02-14 14:43:03 UTC) #5

As discussed, I have submitted this CL as-is, but added a TODO to refactor that
out with an new AST node.

Expand Messages | Collapse Messages