Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: dart/frog/leg/ssa/codegen.dart

Issue 9380006: Support is!. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/ssa/builder.dart ('k') | dart/tests/language/language-leg.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/ssa/codegen.dart
===================================================================
--- dart/frog/leg/ssa/codegen.dart (revision 4223)
+++ dart/frog/leg/ssa/codegen.dart (working copy)
@@ -823,6 +823,7 @@
ClassElement element = node.typeExpression;
LibraryElement coreLibrary = compiler.coreLibrary;
HInstruction input = node.expression;
+ buffer.add('(');
if (element == coreLibrary.find(const SourceString('Object'))) {
// TODO(ahe): This probably belongs in the constant folder.
buffer.add('true');
@@ -835,6 +836,8 @@
} else if (element == coreLibrary.find(const SourceString('bool'))) {
checkBool(input, '===');
} else if (element == coreLibrary.find(const SourceString('int'))) {
+ checkNum(input, '===');
+ buffer.add(' && ');
checkInt(input, '===');
} else {
if (element == coreLibrary.find(const SourceString('List'))) {
@@ -847,6 +850,7 @@
buffer.add(compiler.namer.operatorIs(node.typeExpression));
buffer.add(')');
}
+ buffer.add(')');
}
}
« no previous file with comments | « dart/frog/leg/ssa/builder.dart ('k') | dart/tests/language/language-leg.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698