Issue 9368008: Additional flakiness reducing changes. Also rerun DRT on false positive tests.

Issue 9368008: Additional flakiness reducing changes. Also rerun DRT on false positive tests. (Closed)

Created:
8 years, 10 months ago by Emily Fortuna

Modified:
8 years, 10 months ago

Reviewers:
Bill Hesse, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Additional flakiness reducing changes. Also rerun DRT on false positive tests. Committed: https://code.google.com/p/dart/source/detail?r=4104

Patch Set 3 : '' #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -9 lines)			Patch
M	tools/testing/dart/test_options.dart	View	1 2	1 chunk	+1 line, -0 lines	1 comment	Download
	tools/testing/dart/test_runner.dart	View	1 2	3 chunks	+17 lines, -4 lines	1 comment	Download
M	tools/testing/dart/test_suite.dart	View	1 2	2 chunks	+1 line, -1 line	0 comments	Download
M	tools/testing/run_selenium.py	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

https://chromiumcodereview.appspot.com/9368008/diff/4001/frog/scripts/buildbot_annotated_steps.py File frog/scripts/buildbot_annotated_steps.py (right): https://chromiumcodereview.appspot.com/9368008/diff/4001/frog/scripts/buildbot_annotated_steps.py#newcode172 frog/scripts/buildbot_annotated_steps.py:172: status = BuildFrog(arch, 'release', system) we use "debug" mode ...

8 years, 10 months ago (2012-02-09 23:29:06 UTC) #1

Jennifer Messerly

lgtm! https://chromiumcodereview.appspot.com/9368008/diff/4003/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (right): https://chromiumcodereview.appspot.com/9368008/diff/4003/tools/testing/dart/test_options.dart#newcode429 tools/testing/dart/test_options.dart:429: case 'webdriver': nice :)

8 years, 10 months ago (2012-02-10 00:19:06 UTC) #3

Bill Hesse

8 years, 10 months ago (2012-02-10 09:11:58 UTC) #4

LGTM.

https://chromiumcodereview.appspot.com/9368008/diff/4003/tools/testing/dart/t...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9368008/diff/4003/tools/testing/dart/t...
tools/testing/dart/test_runner.dart:269: testCase.isRerun = true;
testCase.isRerun will be a static type warning.  I would do
testCase.dynamic.isRerun.

Or I would move isRerun to TestCase.

Expand Messages | Collapse Messages