tools/testing/run_selenium.py - Issue 9368008: Additional flakiness reducing changes. Also rerun DRT on false positive tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/run_selenium.py

Issue 9368008: Additional flakiness reducing changes. Also rerun DRT on false positive tests. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: '' Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/run_selenium.py

===================================================================

--- tools/testing/run_selenium.py (revision 4100)

+++ tools/testing/run_selenium.py (working copy)

@@ -90,12 +90,12 @@

parser.add_option('--browser', dest='browser',

help = 'The browser type (default = chrome)',

action = 'store', default = 'chrome')

- # TODO(efortuna): Put this back up to 40 sec. Right now it needs to be less

- # than 20 so that when test.dart times out, this script also closes the

- # browser windows.

+ # TODO(efortuna): Put this back up to be more than the default timeout in

+ # test.dart. Right now it needs to be less than 60 so that when test.dart

+ # times out, this script also closes the browser windows.

parser.add_option('--timeout', dest = 'timeout',

help = 'Amount of time (seconds) to wait before timeout', type = 'int',

- action = 'store', default=18)

+ action = 'store', default=58)

parser.add_option('--perf', dest = 'is_perf',

help = 'Add this flag if we are running a browser performance test',

action = 'store_true', default=False)

« tools/testing/dart/test_runner.dart ('K') | « tools/testing/dart/test_suite.dart ('k') | no next file » | no next file with comments »