Issue 9365050: Fix for issue 1623: bind does not work on safari.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9365050: Fix for issue 1623: bind does not work on safari. (Closed)

Created:
8 years, 10 months ago by ngeoffray

Modified:
8 years, 10 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix for issue 1623: bind does not work on safari. Committed: https://code.google.com/p/dart/source/detail?r=4213

Patch Set 4 : #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -12 lines)			Patch
M	frog/corejs.dart	View	1 2 3	4 chunks	+32 lines, -4 lines	0 comments	Download
M	frog/gen.dart	View	1 2 3	3 chunks	+13 lines, -5 lines	0 comments	Download
M	frog/minfrog	View	1 2 3	7 chunks	+35 lines, -3 lines	0 comments	Download
A	tests/language/BindTest.dart	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/9365050/diff/2001/frog/gen.dart File frog/gen.dart (right): https://chromiumcodereview.appspot.com/9365050/diff/2001/frog/gen.dart#newcode545 frog/gen.dart:545: MethodGenerator._maybeGenerateBoundGetter(m, writer); Do you have to ensure bind ...

8 years, 10 months ago (2012-02-14 11:53:37 UTC) #2

ngeoffray

8 years, 10 months ago (2012-02-14 11:59:21 UTC) #3

https://chromiumcodereview.appspot.com/9365050/diff/2001/frog/gen.dart
File frog/gen.dart (right):

https://chromiumcodereview.appspot.com/9365050/diff/2001/frog/gen.dart#newcod...
frog/gen.dart:545: MethodGenerator._maybeGenerateBoundGetter(m, writer);
On 2012/02/14 11:53:37, kasperl wrote:
> Do you have to ensure bind if maybeGenerateBoundGetter returns false? Maybe it
> never does in this case?

maybeGenerateBoundGetter looks for 'provideGetter' which is true in this
context. I'll check anyways, to not depend on this assumption.

Expand Messages | Collapse Messages

Issue 9365050: Fix for issue 1623: bind does not work on safari. (Closed)

Description

Patch Set 1 : '' #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : #

Messages