Fix for issue 1623: bind does not work on safari.

frog/gen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Top level generator object for writing code and keeping track of
  * dependencies.
  *
  * Should have two compilation models, but only one implemented so far.
  *
@@ skipping 524 matching lines @@
           'set: ${property.declaringType.jsname}.prototype.${property.setter.jsname}');
       }
       writer.exitBlock('});');
     }
   }
 
   _writeMethod(MethodMember m) {
     m.methodData.writeDefinition(m, writer);
 
     if (m.isNative && m._provideGetter) {
       MethodGenerator._maybeGenerateBoundGetter(m, writer);

[kasperl, 2012/02/14 11:53:37]

Do you have to ensure bind if maybeGenerateBoundGetter returns false? Maybe it
never does in this case?

[ngeoffray, 2012/02/14 11:59:21]

maybeGenerateBoundGetter looks for 'provideGetter' which is true in this
context. I'll check anyways, to not depend on this assumption.

+      world.gen.corejs.ensureBind();
     }
   }
 
   writeGlobals() {
     if (globals.length > 0) {
       writer.comment('//  ********** Globals **************');
       var list = globals.getValues();
       list.sort((a, b) => a.compareTo(b));
 
       // put all static field initializations in a method
@@ skipping 341 matching lines @@
     if (_usedTemps.length > 0 || _freeTemps.length > 0) {
       //TODO(jimhug): assert(_usedTemps.length == 0); // all temps should be freed.
       _freeTemps.addAll(_usedTemps);
       _freeTemps.sort((x, y) => x.compareTo(y));
       defWriter.writeln('var ${Strings.join(_freeTemps, ", ")};');
     }
 
     // TODO(jimhug): Lots of string translation here - perf bottleneck?
     defWriter.writeln(writer.text);
 
+    bool usesBind = false;
     if (names != null) {
-      // TODO(jmesserly): bind isn't implemented in older Safari.
+      usesBind = true;
       defWriter.exitBlock('}).bind(null, ${Strings.join(names, ", ")})');
     } else if (isClosure && method.name == '') {
       defWriter.exitBlock('})');
     } else {
       defWriter.exitBlock(suffix);
     }
     if (method.isConstructor && method.constructorName != '') {
       defWriter.writeln(
         '${method.declaringType.jsname}.${method.constructorName}\$ctor.prototype = ' +
         '${method.declaringType.jsname}.prototype;');
     }
 
     _provideOptionalParamInfo(defWriter);
 
     if (method is MethodMember) {
-      _maybeGenerateBoundGetter(method, defWriter);
+      usesBind = _maybeGenerateBoundGetter(method, defWriter);
     }
+
+    if (usesBind) world.gen.corejs.ensureBind();
   }
 
-  static _maybeGenerateBoundGetter(MethodMember m, CodeWriter defWriter) {
+  static bool _maybeGenerateBoundGetter(MethodMember m, CodeWriter defWriter) {
     if (m._provideGetter) {
       String suffix = world.gen._writePrototypePatch(m.declaringType,
           'get\$' + m.jsname, 'function() {', defWriter, false);
-      // TODO(jimhug): Bind not available in older Safari, need fallback?
       defWriter.writeln('return this.${m.jsname}.bind(this);');
       defWriter.exitBlock(suffix);
+      return true;
     }
+    return false;
   }
 
   /**
    * Generates information about the default/named arguments into the JS code.
    * Only methods that are passed as bound methods to "var" need this. It is
    * generated to support run time stub creation.
    */
   _provideOptionalParamInfo(CodeWriter defWriter) {
     if (method is MethodMember) {
       MethodMember meth = method;
@@ skipping 1504 matching lines @@
     return true;
   }
 
 }
 
 class ReturnKind {
   static final int IGNORE = 1;
   static final int POST = 2;
   static final int PRE = 3;
 }