Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 9362013: Remove implicit --optimize from testing dartc component in release mode (Closed)

Created:
8 years, 10 months ago by zundel
Modified:
8 years, 10 months ago
Reviewers:
Bill Hesse, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove implicit --optimize from testing dartc component in release mode Committed: https://code.google.com/p/dart/source/detail?r=4040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -46 lines) Patch
M compiler/tests/dartc/dartc.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/corelib/corelib.status View 2 chunks +0 lines, -8 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language.status View 2 chunks +0 lines, -18 lines 0 comments Download
M tests/stub-generator/stub-generator.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/utils/utils.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zundel
Gets rid of the separate status annotations for release mode on dartc, debug and release ...
8 years, 10 months ago (2012-02-08 15:02:02 UTC) #1
ahe
LGTM!
8 years, 10 months ago (2012-02-08 15:05:27 UTC) #2
Bill Hesse
LGTM. Are we fixing a dartc release mode so it is useful, or should dartc ...
8 years, 10 months ago (2012-02-08 15:10:15 UTC) #3
zundel
8 years, 10 months ago (2012-02-08 15:35:29 UTC) #4
On 2012/02/08 15:10:15, Bill Hesse wrote:
> LGTM.  Are we fixing a dartc release mode so it is useful, or should dartc
> release mode not be run?

Its just as useful as the debug version, it just doesn't behave differently.

Powered by Google App Engine
This is Rietveld 408576698