Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9362013: Remove implicit --optimize from testing dartc component in release mode (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/utils/utils.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index c58c0f6a0ea45e3259aadb889f8873d3aa64b03b..c00b5ed31f2866415b5d7b69183ed8762d0d19e3 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -448,11 +448,9 @@ class StandardTestSuite implements TestSuite {
switch (component) {
case 'chromium':
compilerArgs.addAll(['--work', tempDir.path]);
- if (configuration['mode'] == 'release') {
- compilerArgs.add('--optimize');
- }
compilerArgs.addAll(vmOptions);
compilerArgs.add('--ignore-unrecognized-flags');
+ // TODO(zundel): remove assumption of generated code from dartc
compilerArgs.add('--out');
compilerArgs.add(compiledDartWrapperFilename);
compilerArgs.add(dartWrapperFilename);
@@ -1010,11 +1008,6 @@ class TestUtils {
args.add("--enable_leg");
args.add("--leg_only");
}
- if (configuration["component"] == "dartc") {
- if (configuration["mode"] == "release") {
- args.add("--optimize");
- }
- }
return args;
}
}
« no previous file with comments | « tests/utils/utils.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698