Issue 9361040: Reduce flakiness of browser tests.

Issue 9361040: Reduce flakiness of browser tests. (Closed)

Created:
8 years, 10 months ago by Emily Fortuna

Modified:
8 years, 10 months ago

Reviewers:
Bill Hesse, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Reduce flakiness of browser tests. Committed: https://code.google.com/p/dart/source/detail?r=4044

Patch Set 2 : '' #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -12 lines)			Patch
M	frog/scripts/buildbot_annotated_steps.py	View	1	2 chunks	+0 lines, -8 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/testing/dart/test_runner.dart	View	1	3 chunks	+18 lines, -1 line	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/testing/perf_testing/create_graph.py	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	tools/testing/run_selenium.py	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

https://chromiumcodereview.appspot.com/9361040/diff/2001/tools/testing/run_selenium.py File tools/testing/run_selenium.py (right): https://chromiumcodereview.appspot.com/9361040/diff/2001/tools/testing/run_selenium.py#newcode115 tools/testing/run_selenium.py:115: profile.set_preference('dom.max_script_run_time', 0) This is to prevent Firefox from popping ...

8 years, 10 months ago (2012-02-08 17:55:43 UTC) #1

Emily Fortuna

https://chromiumcodereview.appspot.com/9361040/diff/4001/tools/testing/run_selenium.py File tools/testing/run_selenium.py (right): https://chromiumcodereview.appspot.com/9361040/diff/4001/tools/testing/run_selenium.py#newcode115 tools/testing/run_selenium.py:115: profile.set_preference('dom.max_script_run_time', 0) This is to prevent Firefox from popping ...

8 years, 10 months ago (2012-02-08 18:03:21 UTC) #2

Bill Hesse

8 years, 10 months ago (2012-02-08 18:15:06 UTC) #4

LGTM.

https://chromiumcodereview.appspot.com/9361040/diff/4001/tools/testing/dart/t...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9361040/diff/4001/tools/testing/dart/t...
tools/testing/dart/test_runner.dart:221: testCase.isRerun = true;
Can we print a message in this case?  Is this the best solution for rerunning
tests?  We need the capability to rerun tests for the DumpRenderTree virtual X
server failures - can we add a "request retry" flag to TestOutput, and use that
flag here, so we can request retries in more circumstances?  I think that if we
allow rerunning tests, we should fix the flaky DRT at the same time.

https://chromiumcodereview.appspot.com/9361040/diff/4001/tools/testing/dart/t...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/9361040/diff/4001/tools/testing/dart/t...
tools/testing/dart/test_suite.dart:444: htmlTest.flushSync();
Wow.  Really, we need flush on our writes even if we close?  This needs to be
documented, whenever we get around to explaining the exact semantics of the io
library.

Expand Messages | Collapse Messages