Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 9361040: Reduce flakiness of browser tests. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library("test_suite"); 5 #library("test_suite");
6 6
7 #import("dart:io"); 7 #import("dart:io");
8 #import("status_file_parser.dart"); 8 #import("status_file_parser.dart");
9 #import("test_runner.dart"); 9 #import("test_runner.dart");
10 #import("multitest.dart"); 10 #import("multitest.dart");
(...skipping 423 matching lines...) Expand 10 before | Expand all | Expand 10 after
434 if (new Platform().operatingSystem() == 'windows') { 434 if (new Platform().operatingSystem() == 'windows') {
435 // Firefox on Windows does not like absolute file path names that start 435 // Firefox on Windows does not like absolute file path names that start
436 // with 'C:' adding 'file:///' solves the problem. 436 // with 'C:' adding 'file:///' solves the problem.
437 filePrefix = 'file:///'; 437 filePrefix = 'file:///';
438 } 438 }
439 htmlTest.writeStringSync(GetHtmlContents( 439 htmlTest.writeStringSync(GetHtmlContents(
440 filename, 440 filename,
441 '$filePrefix$dartDir/client/testing/unittest/test_controller.js', 441 '$filePrefix$dartDir/client/testing/unittest/test_controller.js',
442 scriptType, 442 scriptType,
443 filePrefix + scriptPath)); 443 filePrefix + scriptPath));
444 htmlTest.flushSync();
Bill Hesse 2012/02/08 18:15:06 Wow. Really, we need flush on our writes even if
444 htmlTest.closeSync(); 445 htmlTest.closeSync();
445 446
446 List<String> compilerArgs = TestUtils.standardOptions(configuration); 447 List<String> compilerArgs = TestUtils.standardOptions(configuration);
447 String compilerExecutable = TestUtils.compilerPath(configuration); 448 String compilerExecutable = TestUtils.compilerPath(configuration);
448 switch (component) { 449 switch (component) {
449 case 'chromium': 450 case 'chromium':
450 compilerArgs.addAll(['--work', tempDir.path]); 451 compilerArgs.addAll(['--work', tempDir.path]);
451 if (configuration['mode'] == 'release') { 452 if (configuration['mode'] == 'release') {
452 compilerArgs.add('--optimize'); 453 compilerArgs.add('--optimize');
453 } 454 }
(...skipping 609 matching lines...) Expand 10 before | Expand all | Expand 10 after
1063 * $noCrash tests are expected to be flaky but not crash 1064 * $noCrash tests are expected to be flaky but not crash
1064 * $pass tests are expected to pass 1065 * $pass tests are expected to pass
1065 * $failOk tests are expected to fail that we won't fix 1066 * $failOk tests are expected to fail that we won't fix
1066 * $fail tests are expected to fail that we should fix 1067 * $fail tests are expected to fail that we should fix
1067 * $crash tests are expected to crash that we should fix 1068 * $crash tests are expected to crash that we should fix
1068 * $timeout tests are allowed to timeout 1069 * $timeout tests are allowed to timeout
1069 """; 1070 """;
1070 print(report); 1071 print(report);
1071 } 1072 }
1072 } 1073 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698