Remove dartc optimizing backend.

Remove dartc optimizing backend.

Committed: https://code.google.com/p/dart/source/detail?r=4025

[zundel, 2012-02-08 00:22:36]

LGTM just non-blocking nits

http://codereview.chromium.org/9353015/diff/1/dart/compiler/java/com/google/d...
File dart/compiler/java/com/google/dart/compiler/backend/dart/DartBackend.java
(right):

http://codereview.chromium.org/9353015/diff/1/dart/compiler/java/com/google/d...
dart/compiler/java/com/google/dart/compiler/backend/dart/DartBackend.java:64: //
TODO(johnlenz): Determine if we want to make source maps
obsolete comment.

http://codereview.chromium.org/9353015/diff/1/dart/compiler/java/com/google/d...
File
dart/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java
(right):

http://codereview.chromium.org/9353015/diff/1/dart/compiler/java/com/google/d...
dart/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:3732:
private JsExpression generateLoad(DartNode qualifier, DartIdentifier node,
Element element) {
nit, you could remove the third parameter all together, its only invoked with
'null' now.

http://codereview.chromium.org/9353015/diff/1/dart/compiler/javatests/com/goo...
File
dart/compiler/javatests/com/google/dart/compiler/backend/js/JsBackendTests.java
(right):

http://codereview.chromium.org/9353015/diff/1/dart/compiler/javatests/com/goo...
dart/compiler/javatests/com/google/dart/compiler/backend/js/JsBackendTests.java:17:
suite.addTestSuite(JavaScriptStringTest.class);
FYI, I don't think we need any of these tests, even though there is some code
generation still built in so I stripped them out.

http://codereview.chromium.org/9353015/diff/1/dart/tests/corelib/corelib.status
File dart/tests/corelib/corelib.status (right):

http://codereview.chromium.org/9353015/diff/1/dart/tests/corelib/corelib.stat...
dart/tests/corelib/corelib.status:70: [ $component == dartc && $mode == release
]
(This will work, but I was hoping we could just turn off the -release buildbot)

[kasperl, 2012-02-08 08:12:34]

LGTM. Thanks, Peter!

[ahe, 2012-02-08 09:36:10]

Hi Eric and Kasper,

Thank for taking a look.

Cheers,
Peter

http://codereview.chromium.org/9353015/diff/1/dart/compiler/java/com/google/d...
File dart/compiler/java/com/google/dart/compiler/backend/dart/DartBackend.java
(right):

http://codereview.chromium.org/9353015/diff/1/dart/compiler/java/com/google/d...
dart/compiler/java/com/google/dart/compiler/backend/dart/DartBackend.java:64: //
TODO(johnlenz): Determine if we want to make source maps
On 2012/02/08 00:22:36, zundel wrote:
> obsolete comment.

Done.

http://codereview.chromium.org/9353015/diff/1/dart/compiler/java/com/google/d...
File
dart/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java
(right):

http://codereview.chromium.org/9353015/diff/1/dart/compiler/java/com/google/d...
dart/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:3732:
private JsExpression generateLoad(DartNode qualifier, DartIdentifier node,
Element element) {
On 2012/02/08 00:22:36, zundel wrote:
> nit, you could remove the third parameter all together, its only invoked with
> 'null' now.

Done.

http://codereview.chromium.org/9353015/diff/1/dart/compiler/javatests/com/goo...
File
dart/compiler/javatests/com/google/dart/compiler/backend/js/JsBackendTests.java
(right):

http://codereview.chromium.org/9353015/diff/1/dart/compiler/javatests/com/goo...
dart/compiler/javatests/com/google/dart/compiler/backend/js/JsBackendTests.java:17:
suite.addTestSuite(JavaScriptStringTest.class);
On 2012/02/08 00:22:36, zundel wrote:
> FYI, I don't think we need any of these tests, even though there is some code
> generation still built in so I stripped them out.  

This test is empty now and I deleted it.

http://codereview.chromium.org/9353015/diff/1/dart/tests/corelib/corelib.status
File dart/tests/corelib/corelib.status (right):

http://codereview.chromium.org/9353015/diff/1/dart/tests/corelib/corelib.stat...
dart/tests/corelib/corelib.status:70: [ $component == dartc && $mode == release
]
On 2012/02/08 00:22:36, zundel wrote:
> (This will work, but I was hoping we could just turn off the -release
buildbot)

Regardless, "test.py -cdartc -mrelease" should still work.

[scheglov, 2012-02-08 12:56:38]

LGTM for dart-compiler.gyp

You are right, we don't generate *.api files anymore, but we still (and don't
have yet plans to remove) generate *.deps files.

[zundel, 2012-02-08 13:49:34]

http://codereview.chromium.org/9353015/diff/1/dart/tests/corelib/corelib.status
File dart/tests/corelib/corelib.status (right):

http://codereview.chromium.org/9353015/diff/1/dart/tests/corelib/corelib.stat...
dart/tests/corelib/corelib.status:70: [ $component == dartc && $mode == release
]
On 2012/02/08 09:36:10, ahe wrote:
> On 2012/02/08 00:22:36, zundel wrote:
> > (This will work, but I was hoping we could just turn off the -release
> buildbot)
> 
> Regardless, "test.py -cdartc -mrelease" should still work.

Here's what I'd rather do.

remove the implicit --optimize flag from the test infrastructure build when mode
is release.

remove all instances of separating out $component == dartc && $mode == release
because the tests should work the same either way.

[zundel, 2012-02-08 14:18:15]

FYI, I see this review is closed, I'll submit the release mode changes myself.

[ahe, 2012-02-08 14:56:59]

On 2012/02/08 14:18:15, zundel wrote:
> FYI, I see this review is closed, I'll submit the release mode changes myself.

Thank you, Eric. I don't know why I didn't think of updating the test
configuration. That is a much better idea.

Cheers,
Peter

[ahe, 2012-02-08 14:57:52]

On 2012/02/08 12:56:38, scheglov wrote:
> LGTM for dart-compiler.gyp
> 
> You are right, we don't generate *.api files anymore, but we still (and don't
> have yet plans to remove) generate *.deps files.

Hi Konstantin,

Thank you for confirming.

Cheers,
Peter