Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: dart/compiler/java/com/google/dart/compiler/backend/dart/DartBackend.java

Issue 9353015: Remove dartc optimizing backend. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix minor test issues Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/compiler/java/com/google/dart/compiler/backend/dart/DartBackend.java
diff --git a/dart/compiler/java/com/google/dart/compiler/backend/dart/DartBackend.java b/dart/compiler/java/com/google/dart/compiler/backend/dart/DartBackend.java
index 661d53cf74e4eaebb45474bb3c9c3bbf75b52c59..1cbccf86c671ed0d38462985417fe4882e872ee8 100644
--- a/dart/compiler/java/com/google/dart/compiler/backend/dart/DartBackend.java
+++ b/dart/compiler/java/com/google/dart/compiler/backend/dart/DartBackend.java
@@ -6,13 +6,13 @@ package com.google.dart.compiler.backend.dart;
import com.google.common.io.CharStreams;
import com.google.common.io.Closeables;
+import com.google.dart.compiler.Backend;
import com.google.dart.compiler.DartCompilerContext;
import com.google.dart.compiler.DartSource;
import com.google.dart.compiler.LibrarySource;
import com.google.dart.compiler.ast.DartToSourceVisitor;
import com.google.dart.compiler.ast.DartUnit;
import com.google.dart.compiler.ast.LibraryUnit;
-import com.google.dart.compiler.backend.common.AbstractBackend;
import com.google.dart.compiler.resolver.CoreTypeProvider;
import com.google.dart.compiler.util.DefaultTextOutput;
import com.google.dart.compiler.util.TextOutput;
@@ -25,12 +25,9 @@ import java.util.Collection;
/**
* A compiler backend that produces optimized Dart.
*/
-public class DartBackend extends AbstractBackend {
+public class DartBackend implements Backend {
public static final String EXTENSION_DART = "opt.dart";
- public static final String EXTENSION_DART_SRC_MAP = "opt.dart.map";
-
-
private static void packageLibs(Collection<LibraryUnit> libraries,
Writer w,
@@ -64,9 +61,6 @@ public class DartBackend extends AbstractBackend {
// Generate Javascript output.
TextOutput out = new DefaultTextOutput(false);
DartToSourceVisitor srcGenerator = new DartToSourceVisitor(out);
- // TODO(johnlenz): Determine if we want to make source maps
- // optional.
- srcGenerator.generateSourceMap(true);
srcGenerator.accept(unit);
Writer w = context.getArtifactWriter(src, "", EXTENSION_DART);
boolean failed = true;
@@ -76,15 +70,6 @@ public class DartBackend extends AbstractBackend {
} finally {
Closeables.close(w, failed);
}
- // Write out the source map.
- w = context.getArtifactWriter(src, "", EXTENSION_DART_SRC_MAP);
- failed = true;
- try {
- srcGenerator.writeSourceMap(w, src.getName());
- failed = false;
- } finally {
- Closeables.close(w, failed);
- }
}
@Override
@@ -111,9 +96,4 @@ public class DartBackend extends AbstractBackend {
public String getAppExtension() {
return EXTENSION_DART;
}
-
- @Override
- public String getSourceMapExtension() {
- return EXTENSION_DART_SRC_MAP;
- }
}

Powered by Google App Engine
This is Rietveld 408576698