Issue 9352016: Fix split with regexp for frog.

Issue 9352016: Fix split with regexp for frog. (Closed)

Created:
8 years, 10 months ago by floitsch

Modified:
8 years, 10 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix split with regexp for frog. Committed: https://code.google.com/p/dart/source/detail?r=3998

Patch Set 2 : Update test and status file.wq #

Patch Set 3 : Use existing style. #

Total comments: 8

Patch Set 4 : Move regexp-split test into separate file. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -2 lines)			Patch
M	frog/lib/string_implementation.dart	View	1 2	1 chunk	+10 lines, -2 lines	0 comments	Download
M	frog/world.dart	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	tests/corelib/corelib.status	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/corelib/corelib-leg.status	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/corelib/src/StringSplitRegExpTest.dart	View	1 2 3	1 chunk	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/9352016/diff/4001/frog/world.dart File frog/world.dart (right): https://chromiumcodereview.appspot.com/9352016/diff/4001/frog/world.dart#newcode333 frog/world.dart:333: // Hack: we don't want Dart's String.split to ...

8 years, 10 months ago (2012-02-07 12:32:30 UTC) #2

kasperl

https://chromiumcodereview.appspot.com/9352016/diff/4001/tests/corelib/src/StringSplitTest.dart File tests/corelib/src/StringSplitTest.dart (right): https://chromiumcodereview.appspot.com/9352016/diff/4001/tests/corelib/src/StringSplitTest.dart#newcode42 tests/corelib/src/StringSplitTest.dart:42: splitRegExp() { On 2012/02/07 12:32:30, kasperl wrote: > testSplitRegExp? ...

8 years, 10 months ago (2012-02-07 12:34:09 UTC) #3

floitsch

8 years, 10 months ago (2012-02-07 15:06:29 UTC) #4

https://chromiumcodereview.appspot.com/9352016/diff/4001/frog/world.dart
File frog/world.dart (right):

https://chromiumcodereview.appspot.com/9352016/diff/4001/frog/world.dart#newc...
frog/world.dart:333: // Hack: we don't want Dart's String.split to overwrite the
existing
On 2012/02/07 12:32:30, kasperl wrote:
> Maybe explain this a bit better. Elaborate.

Done.

https://chromiumcodereview.appspot.com/9352016/diff/4001/tests/corelib/src/St...
File tests/corelib/src/StringSplitTest.dart (right):

https://chromiumcodereview.appspot.com/9352016/diff/4001/tests/corelib/src/St...
tests/corelib/src/StringSplitTest.dart:5: splitString() {
On 2012/02/07 12:32:30, kasperl wrote:
> testSplitString?

kept original file as is.

https://chromiumcodereview.appspot.com/9352016/diff/4001/tests/corelib/src/St...
tests/corelib/src/StringSplitTest.dart:42: splitRegExp() {
On 2012/02/07 12:34:09, kasperl wrote:
> On 2012/02/07 12:32:30, kasperl wrote:
> > testSplitRegExp?
> 
> Maybe it would be even better to add this in a new file so you don't lose the
> VMs test coverage on the string splitting implementation?

Done.

https://chromiumcodereview.appspot.com/9352016/diff/4001/tests/corelib/src/St...
tests/corelib/src/StringSplitTest.dart:42: splitRegExp() {
On 2012/02/07 12:32:30, kasperl wrote:
> testSplitRegExp?

now in main().

Expand Messages | Collapse Messages