frog/world.dart - Issue 9352016: Fix split with regexp for frog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: frog/world.dart

Issue 9352016: Fix split with regexp for frog. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Move regexp-split test into separate file. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: frog/world.dart

diff --git a/frog/world.dart b/frog/world.dart

index e20bc1c22e76fbc95e3eacc1465b10a2d2357234..74f12a2dbd7881575d782570c09e76863f6354a0 100644

--- a/frog/world.dart

+++ b/frog/world.dart

@@ -330,6 +330,11 @@ class World {

'class', 'enum', 'export', 'extends', 'import', 'super',

'implements', 'interface', 'let', 'package', 'private',

'protected', 'public', 'static', 'yield',

+ // Hack: we don't want Dart's String.split to overwrite the existing

+ // JS String.split method. By adding 'split' to the keyword-set we

+ // ensure that frog will not use the 'split' name but mangle it, thus

+ // leaving the original JS String.split untouched.

+ 'split',

'native']);

}

if (_jsKeywords.contains(name)) {

« no previous file with comments | « frog/lib/string_implementation.dart ('k') | tests/corelib/corelib.status » ('j') | no next file with comments »