Support 'Conditional' idl attribute.

Support 'Conditional' idl attribute.

'Conditional' attribute is a replacement for "#if defined" conditions and should be processed accordingly.

R=sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=3939

[sra1, 2012-02-03 20:53:56]

lgtm

https://chromiumcodereview.appspot.com/9323028/diff/1/client/dom/scripts/data...
File client/dom/scripts/databasebuilder.py (right):

https://chromiumcodereview.appspot.com/9323028/diff/1/client/dom/scripts/data...
client/dom/scripts/databasebuilder.py:492: if self._is_node_enabled(attribute,
import_options.idl_defines)]
you might define a local function and use filter:

@line 482
def enabled(idl_node):
  return self._is_enabled(idl_node, import_options.idl_defines


        interface.attributes = filter(enabled, interface.attributes)

https://chromiumcodereview.appspot.com/9323028/diff/1/client/dom/scripts/data...
client/dom/scripts/databasebuilder.py:509: for condition in
conditional.split('&'):
can & and | occur together?

[podivilov, 2012-02-06 12:09:40]

Thanks!

http://codereview.chromium.org/9323028/diff/1/client/dom/scripts/databasebuil...
File client/dom/scripts/databasebuilder.py (right):

http://codereview.chromium.org/9323028/diff/1/client/dom/scripts/databasebuil...
client/dom/scripts/databasebuilder.py:492: if self._is_node_enabled(attribute,
import_options.idl_defines)]
On 2012/02/03 20:53:56, sra1 wrote:
> you might define a local function and use filter:
> 
> @line 482
> def enabled(idl_node):
>   return self._is_enabled(idl_node, import_options.idl_defines
> 
> 
>         interface.attributes = filter(enabled, interface.attributes)

Done.

http://codereview.chromium.org/9323028/diff/1/client/dom/scripts/databasebuil...
client/dom/scripts/databasebuilder.py:509: for condition in
conditional.split('&'):
On 2012/02/03 20:53:56, sra1 wrote:
> can & and | occur together?

AFAIK they could not, and webkit code generators don't support it.

[sra1, 2012-02-06 20:18:00]

On 2012/02/06 12:09:40, podivilov wrote:
> Thanks!
> 
>
http://codereview.chromium.org/9323028/diff/1/client/dom/scripts/databasebuil...
> File client/dom/scripts/databasebuilder.py (right):
> 
>
http://codereview.chromium.org/9323028/diff/1/client/dom/scripts/databasebuil...
> client/dom/scripts/databasebuilder.py:492: if self._is_node_enabled(attribute,
> import_options.idl_defines)]
> On 2012/02/03 20:53:56, sra1 wrote:
> > you might define a local function and use filter:
> > 
> > @line 482
> > def enabled(idl_node):
> >   return self._is_enabled(idl_node, import_options.idl_defines
> > 
> > 
> >         interface.attributes = filter(enabled, interface.attributes)
> 
> Done.
> 
>
http://codereview.chromium.org/9323028/diff/1/client/dom/scripts/databasebuil...
> client/dom/scripts/databasebuilder.py:509: for condition in
> conditional.split('&'):
> On 2012/02/03 20:53:56, sra1 wrote:
> > can & and | occur together?
> 
> AFAIK they could not, and webkit code generators don't support it.

Do you know why HTMLContentElement was deleted?
It is conditional on SHADOW_DOM.
Is it just an omission, or is there some reason to exclude shadow dom?

[podivilov, 2012-02-07 12:31:18]

On 2012/02/06 20:18:00, sra1 wrote:
> On 2012/02/06 12:09:40, podivilov wrote:
> > Thanks!
> > 
> >
>
http://codereview.chromium.org/9323028/diff/1/client/dom/scripts/databasebuil...
> > File client/dom/scripts/databasebuilder.py (right):
> > 
> >
>
http://codereview.chromium.org/9323028/diff/1/client/dom/scripts/databasebuil...
> > client/dom/scripts/databasebuilder.py:492: if
self._is_node_enabled(attribute,
> > import_options.idl_defines)]
> > On 2012/02/03 20:53:56, sra1 wrote:
> > > you might define a local function and use filter:
> > > 
> > > @line 482
> > > def enabled(idl_node):
> > >   return self._is_enabled(idl_node, import_options.idl_defines
> > > 
> > > 
> > >         interface.attributes = filter(enabled, interface.attributes)
> > 
> > Done.
> > 
> >
>
http://codereview.chromium.org/9323028/diff/1/client/dom/scripts/databasebuil...
> > client/dom/scripts/databasebuilder.py:509: for condition in
> > conditional.split('&'):
> > On 2012/02/03 20:53:56, sra1 wrote:
> > > can & and | occur together?
> > 
> > AFAIK they could not, and webkit code generators don't support it.
> 
> Do you know why HTMLContentElement was deleted?
> It is conditional on SHADOW_DOM.
> Is it just an omission, or is there some reason to exclude shadow dom?

I believe that chrome is now built with SHADOW_DOM enabled, so we can add it to
webkit_defines list in fremontcutbuilder.py.