Support 'Conditional' idl attribute.

client/dom/scripts/databasebuilder.py

 #!/usr/bin/python
 # Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 import copy
 import database
 import idlparser
 import logging
 import os
@@ skipping 461 matching lines @@
             import_options=DatabaseBuilderOptions()):
     """Parses, loads into memory and cleans up and IDL file"""
     idl_file = self._load_idl_file(file_path, import_options)
 
     self._strip_ext_attributes(idl_file)
     self._resolve_type_defs(idl_file)
     self._rename_types(idl_file, import_options)
 
     for module in idl_file.modules:
       for interface in module.interfaces:
+        if not self._is_node_enabled(interface, import_options.idl_defines):
+          _logger.info('skipping interface %s/%s (source=%s file=%s)'
+            % (module.id, interface.id, import_options.source,
+               file_path))
+          continue
+
         _logger.info('importing interface %s/%s (source=%s file=%s)'
           % (module.id, interface.id, import_options.source,
              file_path))
-        self._imported_interfaces.append(
-          (interface, module.id, import_options))
+        interface.attributes = [attribute for attribute in interface.attributes
+            if self._is_node_enabled(attribute, import_options.idl_defines)]

[sra1, 2012/02/03 20:53:56]

you might define a local function and use filter:

@line 482
def enabled(idl_node):
  return self._is_enabled(idl_node, import_options.idl_defines


        interface.attributes = filter(enabled, interface.attributes)

[podivilov, 2012/02/06 12:09:40]

Done.

+        interface.operations = [operation for operation in interface.operations
+            if self._is_node_enabled(operation, import_options.idl_defines)]
+        self._imported_interfaces.append((interface, module.id, import_options))
+
       for implStmt in module.implementsStatements:
         self._impl_stmts.append((implStmt, import_options))
 
+  def _is_node_enabled(self, node, idl_defines):
+    if not 'Conditional' in node.ext_attrs:
+      return True
+
+    def enabled(condition):
+      return 'ENABLE_%s' % condition in idl_defines
+
+    conditional = node.ext_attrs['Conditional']
+    if conditional.find('&') != -1:
+      for condition in conditional.split('&'):

[sra1, 2012/02/03 20:53:56]

can & and | occur together?

[podivilov, 2012/02/06 12:09:40]

AFAIK they could not, and webkit code generators don't support it.

+        if not enabled(condition):
+          return False
+      return True
+
+    for condition in conditional.split('|'):
+      if enabled(condition):
+        return True
+    return False
+
   def import_idl_directory(self, directory_path,
                import_options=DatabaseBuilderOptions()):
     """Parses, loads into memory and cleans up all IDL files in a given
     directory"""
     if not os.path.exists(directory_path):
       raise RuntimeError('directory not found: %s' % directory_path)
 
     def visitor(arg, dir_name, names):
       module = dir_name[len(directory_path) + 1:]
       for name in names:
@@ skipping 65 matching lines @@
             annotation = idl_node.annotations[source]
             for name, value in annotation.items():
               if (name in top_level_annotation
                   and value == top_level_annotation[name]):
                 del annotation[name]
 
         map(normalize, interface.parents)
         map(normalize, interface.constants)
         map(normalize, interface.attributes)
         map(normalize, interface.operations)