Issue 9320038: Move test.dart's check for missing test directories from co19 to general framework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9320038: Move test.dart's check for missing test directories from co19 to general framework. (Closed)

Created:
8 years, 10 months ago by Bill Hesse

Modified:
8 years, 10 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move test.dart's check for missing test directories from co19 to general framework. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3886

Patch Set 2 : Address comment, add error if status file not found. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -18 lines)			Patch
M	tests/co19/test_config.dart	View	1	2 chunks	+1 line, -14 lines	0 comments	Download
M	tools/testing/dart/status_file_parser.dart	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1	1 chunk	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

https://chromiumcodereview.appspot.com/9320038/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://chromiumcodereview.appspot.com/9320038/diff/1/tools/testing/dart/test_suite.dart#newcode227 tools/testing/dart/test_suite.dart:227: if (!dir.existsSync()) { Since you really want this to ...

8 years, 10 months ago (2012-02-02 14:33:05 UTC) #2

Bill Hesse

Used async Directory.exists. Report error when status file does not exist.

8 years, 10 months ago (2012-02-03 09:35:13 UTC) #3

LGTM!

Expand Messages | Collapse Messages

Issue 9320038: Move test.dart's check for missing test directories from co19 to general framework. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment, add error if status file not found. #

Messages