Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 9316071: Dart_PropagateError, take 2. (Closed)

Created:
8 years, 10 months ago by turnidge
Modified:
8 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Dart_PropagateError, take 2. This change hopefully takes care of the non-mac build issues. The checked mode failures are fixed in a separate cl. Committed: https://code.google.com/p/dart/source/detail?r=3863

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+952 lines, -698 lines) Patch
M runtime/include/dart_api.h View 1 chunk +24 lines, -0 lines 0 comments Download
M runtime/lib/isolate.cc View 6 chunks +21 lines, -18 lines 0 comments Download
M runtime/vm/ast.cc View 1 chunk +11 lines, -9 lines 0 comments Download
M runtime/vm/bootstrap.h View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/bootstrap.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M runtime/vm/bootstrap_nocorelib.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/code_generator.cc View 9 chunks +41 lines, -25 lines 0 comments Download
M runtime/vm/code_generator_ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/code_generator_ia32_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/code_generator_x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/code_generator_x64_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/compiler.h View 1 chunk +16 lines, -5 lines 0 comments Download
M runtime/vm/compiler.cc View 3 chunks +230 lines, -177 lines 0 comments Download
M runtime/vm/cpu.h View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/cpu_arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/cpu_ia32.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M runtime/vm/cpu_x64.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/dart.h View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/dart.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 23 chunks +141 lines, -267 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M runtime/vm/dart_entry.h View 2 chunks +22 lines, -22 lines 0 comments Download
M runtime/vm/dart_entry.cc View 11 chunks +31 lines, -19 lines 0 comments Download
M runtime/vm/dart_entry_test.cc View 2 chunks +71 lines, -0 lines 0 comments Download
M runtime/vm/debugger.h View 2 chunks +6 lines, -3 lines 0 comments Download
M runtime/vm/debugger.cc View 4 chunks +13 lines, -6 lines 0 comments Download
M runtime/vm/debugger_api_impl.cc View 3 chunks +18 lines, -24 lines 0 comments Download
M runtime/vm/exceptions.h View 2 chunks +7 lines, -3 lines 0 comments Download
M runtime/vm/exceptions.cc View 3 chunks +62 lines, -7 lines 0 comments Download
M runtime/vm/isolate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M runtime/vm/longjump.h View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/longjump.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 5 chunks +16 lines, -6 lines 0 comments Download
M runtime/vm/object_store.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object_store.cc View 2 chunks +16 lines, -14 lines 0 comments Download
M runtime/vm/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 8 chunks +54 lines, -21 lines 0 comments Download
M runtime/vm/stack_frame.cc View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/unit_test.h View 2 chunks +10 lines, -4 lines 0 comments Download
M runtime/vm/unit_test.cc View 1 chunk +4 lines, -24 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
turnidge
Recommitting my earlier change, with build fixes. TBR=asiva
8 years, 10 months ago (2012-02-02 19:04:38 UTC) #1
siva
8 years, 10 months ago (2012-02-02 19:55:57 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698