Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: runtime/vm/longjump.cc

Issue 9316071: Dart_PropagateError, take 2. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/longjump.h ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/longjump.cc
===================================================================
--- runtime/vm/longjump.cc (revision 3862)
+++ runtime/vm/longjump.cc (working copy)
@@ -20,9 +20,20 @@
}
+bool LongJump::IsSafeToJump() {
+ // We do not want to jump past Dart frames. Note that this code
+ // assumes the stack grows from high to low.
+ Isolate* isolate = Isolate::Current();
+ uword jumpbuf_addr = reinterpret_cast<uword>(this);
+ return (isolate->top_exit_frame_info() == 0 ||
+ jumpbuf_addr < isolate->top_exit_frame_info());
+}
+
+
void LongJump::Jump(int value, const Error& error) {
// A zero is the default return value from setting up a LongJump using Set.
ASSERT(value != 0);
+ ASSERT(IsSafeToJump());
Isolate* isolate = Isolate::Current();
« no previous file with comments | « runtime/vm/longjump.h ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698