Issue 9310113: Debug means debug build, --checked is a seperate step

Issue 9310113: Debug means debug build, --checked is a seperate step (Closed)

Created:
8 years, 10 months ago by ahe

Modified:
8 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang), ngeoffray, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Debug means debug build, --checked is a seperate step Committed: https://code.google.com/p/dart/source/detail?r=3935

Patch Set 2 : Address review comments #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -39 lines)			Patch
M	dart/frog/presubmit.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	dart/frog/scripts/buildbot_annotated_steps.py	View	1	4 chunks	+42 lines, -28 lines	2 comments	Download
M	dart/tests/co19/co19-frog.status	View		5 chunks	+15 lines, -11 lines	0 comments	Download
M	dart/tests/corelib/corelib-leg.status	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	dart/tests/language/language-leg.status	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/9310113/diff/1/dart/frog/scripts/buildbot_annotated_steps.py File dart/frog/scripts/buildbot_annotated_steps.py (right): https://chromiumcodereview.appspot.com/9310113/diff/1/dart/frog/scripts/buildbot_annotated_steps.py#newcode101 dart/frog/scripts/buildbot_annotated_steps.py:101: - mode: either 'debug' (with type checks) or ...

8 years, 10 months ago (2012-02-06 11:28:35 UTC) #2

ahe

Hi Kasper, Thank you for taking a look! Cheers, Peter https://chromiumcodereview.appspot.com/9310113/diff/1/dart/frog/scripts/buildbot_annotated_steps.py File dart/frog/scripts/buildbot_annotated_steps.py (right): https://chromiumcodereview.appspot.com/9310113/diff/1/dart/frog/scripts/buildbot_annotated_steps.py#newcode101 ...

8 years, 10 months ago (2012-02-06 11:37:01 UTC) #3

Siggi Cherem (dart-lang)

8 years, 10 months ago (2012-02-06 17:48:16 UTC) #5

https://chromiumcodereview.appspot.com/9310113/diff/2002/dart/frog/scripts/bu...
File dart/frog/scripts/buildbot_annotated_steps.py (right):

https://chromiumcodereview.appspot.com/9310113/diff/2002/dart/frog/scripts/bu...
dart/frog/scripts/buildbot_annotated_steps.py:46: print '@@@BUILD_STEP %s tests:
%s %s@@@' % (name, component, flags)
Maybe do: ' '.join(flags), so it reads better in the build bot UI?

https://chromiumcodereview.appspot.com/9310113/diff/2002/dart/frog/scripts/bu...
dart/frog/scripts/buildbot_annotated_steps.py:92: return subprocess.call(
I'm not sure how the buildbot scripts handle an exit code != than 0 or 1. I
think it should be ok, but I somehow prefer making the current file return 1 for
any error case.

Expand Messages | Collapse Messages