dart/frog/presubmit.py - Issue 9310113: Debug means debug build, --checked is a seperate step

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/frog/presubmit.py

Issue 9310113: Debug means debug build, --checked is a seperate step (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review comments Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/frog/presubmit.py

diff --git a/dart/frog/presubmit.py b/dart/frog/presubmit.py

index bb594af68bdf4026ac4fa857200e54a31459257f..c378a1d273dce4dca06a38d003f879e2e6e0f33e 100755

--- a/dart/frog/presubmit.py

+++ b/dart/frog/presubmit.py

@@ -152,6 +152,9 @@ def main():

cmd = test_cmd + ['--component=vm', 'leg']

RunCommand(*cmd, verbose=True)

+ # Leg does not implement checked mode yet.

+ test_cmd.remove('--checked')

cmd = test_cmd + ['--component=leg', 'leg_only']

RunCommand(*cmd, verbose=True)