Issue 9301037: Made multiline string literals ignore an initial newline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9301037: Made multiline string literals ignore an initial newline. (Closed)

Created:
8 years, 10 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 10 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Made multiline string literals ignore an initial newline. Committed: https://code.google.com/p/dart/source/detail?r=3779

Patch Set 1 #

Total comments: 1

Patch Set 2 : Avoid unnecessary call in assert. #

Patch Set 3 : Fix test that didn't expect initial newlines to disappear. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -58 lines)			Patch
M	frog/leg/scanner/byte_strings.dart	View	1	1 chunk	+11 lines, -21 lines	0 comments	Download
M	frog/leg/scanner/string_scanner.dart	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	frog/leg/scanner/token.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	frog/leg/string_validator.dart	View		2 chunks	+18 lines, -4 lines	0 comments	Download
M	frog/leg/tree/nodes.dart	View	1 2	1 chunk	+46 lines, -17 lines	0 comments	Download
M	frog/tests/leg/src/StringEscapesTest.dart	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/language/language-leg.status	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years, 10 months ago (2012-01-31 14:08:31 UTC) #2

LGTM!

https://chromiumcodereview.appspot.com/9301037/diff/1/frog/leg/scanner/byte_s...
File frog/leg/scanner/byte_strings.dart (right):

https://chromiumcodereview.appspot.com/9301037/diff/1/frog/leg/scanner/byte_s...
frog/leg/scanner/byte_strings.dart:122: }());
You don't need to call the function.

Expand Messages | Collapse Messages