Made multiline string literals ignore an initial newline.

frog/leg/scanner/byte_strings.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * An abstract string representation.
  */
 class ByteString implements SourceString {
   final List<int> bytes;
   final int offset;
@@ skipping 91 matching lines @@
     return new Utf8String(bytes, offset, length);
   }
 
   static Utf8String fromString(String string) {
     throw "not implemented yet";
   }
 
   Iterator<int> iterator() => new Utf8Decoder(bytes, 0, length);
 
   SourceString copyWithoutQuotes(int initial, int terminal) {
-    assert(0 <= initial && initial <= 4);
-    assert(initial !== 1 || bytes[offset] === $SQ ||
-                            bytes[offset] === $DQ);
-    assert(initial !== 2 || (bytes[offset] === $AT &&
-                             (bytes[offset + 1] === $SQ ||
-                              bytes[offset + 1] === $DQ)));
-    assert(initial !== 3 || ((bytes[offset] === $SQ ||
-                              bytes[offset] === $DQ) &&
-                             bytes[offset] === bytes[offset + 1] &&
-                             bytes[offset] === bytes[offset + 2]));
-    assert(initial !== 4 || (bytes[offset] === $AT &&
-                             (bytes[offset + 1] === $SQ ||
-                              bytes[offset + 1] === $DQ) &&
-                              bytes[offset + 2] === bytes[offset + 1] &&
-                              bytes[offset + 3] === bytes[offset + 1]));
-    assert(terminal === 0 || terminal === 1 || terminal === 3);
-    assert(terminal === 0 || ((bytes[end - 1] == $AT ||
-                               bytes[end - 1] === $DQ) &&
-                               (terminal === 1 ||
-                                bytes[end - 2] === bytes[end - 1] &&
-                                bytes[end - 3] === bytes[end - 1])));
+    assert((){
+      // Only allow dropping ASCII characters, to guarantee that
+      // the resulting Utf8String is still valid.
+      for (int i = 0; i < initial; i++) {
+        if (bytes[offset + i] >= 0x80) return false;
+      }
+      for (int i = 0; i < terminal; i++) {
+        if (bytes[offset + length - terminal + i] >= 0x80) return false;
+      }
+      return true;
+    }());

[ahe, 2012/01/31 14:08:32]

You don't need to call the function.

     // TODO(lrn): Check that first and last bytes use the same type of quotes.
     return new Utf8String(bytes, offset + initial,
                           length - initial - terminal);
   }
 }
 
 /**
  * A ByteString-valued token.
  */
 class ByteStringToken extends Token {
   final ByteString value;
 
   ByteStringToken(PrecedenceInfo info, ByteString this.value, int charOffset)
     : super(info, charOffset);
 
   String toString() => value.toString();
 }