Added runtime type checking to the elements of list and map literals in dartc

Added runtime type checking to the elements of list and map literals in dartc

http://code.google.com/p/dart/issues/detail?id=220
http://code.google.com/p/dart/issues/detail?id=221

Committed: https://code.google.com/p/dart/source/detail?r=3619

[zundel, 2012-01-25 23:41:22]

https://chromiumcodereview.appspot.com/9289029/diff/1/tests/language/src/List...
File tests/language/src/ListLiteral4Test.dart (right):

https://chromiumcodereview.appspot.com/9289029/diff/1/tests/language/src/List...
tests/language/src/ListLiteral4Test.dart:23: var m = <T>["a", "b"];  // "b" is
not an int.
My guess is this was some kind of cut and paste error when this part of the test
was cloned from MapLiteral4Test.

[scheglov, 2012-01-26 15:54:42]

lgtm

https://chromiumcodereview.appspot.com/9289029/diff/1/compiler/java/com/googl...
File
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java
(right):

https://chromiumcodereview.appspot.com/9289029/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:3314:
JsExpression expr = (JsExpression)generate(node);
(JsExpression)generate(node)
space is missing

https://chromiumcodereview.appspot.com/9289029/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:3347:
x.getType().getArguments().get(1)));
x.getType().getArguments().get(1)
can be extracted into local variable outside of the loop

https://chromiumcodereview.appspot.com/9289029/diff/1/tests/language/src/MapL...
File tests/language/src/MapLiteral1NegativeTest.dart (right):

https://chromiumcodereview.appspot.com/9289029/diff/1/tests/language/src/MapL...
tests/language/src/MapLiteral1NegativeTest.dart:6: // When type checks are
enabled, a type mismatch in an array literal is a compile-time error
"array literal"?
Probably "map literal".

[zundel, 2012-01-26 17:39:51]

r3619

https://chromiumcodereview.appspot.com/9289029/diff/1/compiler/java/com/googl...
File
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java
(right):

https://chromiumcodereview.appspot.com/9289029/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:3314:
JsExpression expr = (JsExpression)generate(node);
On 2012/01/26 15:54:42, scheglov wrote:
> (JsExpression)generate(node)
> space is missing

Done.

https://chromiumcodereview.appspot.com/9289029/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:3347:
x.getType().getArguments().get(1)));
On 2012/01/26 15:54:42, scheglov wrote:
> x.getType().getArguments().get(1)
> can be extracted into local variable outside of the loop

Done.

https://chromiumcodereview.appspot.com/9289029/diff/1/tests/language/src/MapL...
File tests/language/src/MapLiteral1NegativeTest.dart (right):

https://chromiumcodereview.appspot.com/9289029/diff/1/tests/language/src/MapL...
tests/language/src/MapLiteral1NegativeTest.dart:6: // When type checks are
enabled, a type mismatch in an array literal is a compile-time error
On 2012/01/26 15:54:42, scheglov wrote:
> "array literal"?
> Probably "map literal".

Done.

[gbracha, 2012-01-26 18:32:34]

Tests LGTM.  Did not look at Java code.