compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java - Issue 9289029: Added runtime type checking to the elements of list and map literals in dartc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java

Issue 9289029: Added runtime type checking to the elements of list and map literals in dartc (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java ('K') | « compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java ('k') | compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java » ('j') | tests/language/src/ListLiteral4Test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java

diff --git a/compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java b/compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java

index 265472f6c74b266183658e2099387f22441534f2..179767e1308e806d71e0e56676d380fea26091c4 100644

--- a/compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java

+++ b/compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java

@@ -1150,7 +1150,8 @@ public class RuntimeTypeInjector {

* @param enclosingClass enclosing class element

* @param expr expression to check

- * @param type {@link Type} to check against, null is unknown

+ * @param type {@link Type} expected type to check against, null is unknown

+ * @param exprType {@link Type} statically determined type from analyzing expr

* @param src source info to use for the generated code

* @return an expression wrapping the type check call