Build script tags.

Build script tags.

For now, ignore script tags but warn that they aren't supported. This flushes out bugs elsewhere in the compiler.

Committed: https://code.google.com/p/dart/source/detail?r=3594

[ngeoffray, 2012-01-25 09:04:59]

LGTM with comments

https://chromiumcodereview.appspot.com/9283031/diff/1/dart/frog/leg/elements/...
File dart/frog/leg/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/9283031/diff/1/dart/frog/leg/elements/...
dart/frog/leg/elements/elements.dart:89: class EnclosingElement extends Element
{
EnclosingElement -> ContainerElement?

Because other elements can be enclosing (eg a method), calling this class
EnclosingElement makes things confusing.

https://chromiumcodereview.appspot.com/9283031/diff/1/dart/frog/leg/elements/...
dart/frog/leg/elements/elements.dart:111: Element existing =
scope.putIfAbsent(element.name, ()=>element);
spaces around => ?

https://chromiumcodereview.appspot.com/9283031/diff/1/dart/frog/leg/elements/...
dart/frog/leg/elements/elements.dart:112: if (existing !== element) {
Is this the right place to do it? Do we want a per-compilation unit error, or a
per-library error? It looks to me that the library will have to create the scope
and run through the topLevelElements of its compilation units, in order to
report duplicates.

https://chromiumcodereview.appspot.com/9283031/diff/1/dart/frog/leg/universe....
File dart/frog/leg/universe.dart (right):

https://chromiumcodereview.appspot.com/9283031/diff/1/dart/frog/leg/universe....
dart/frog/leg/universe.dart:31: Element existing =
elements.putIfAbsent(element.name, ()=>element);
spaces around => ?

[ahe, 2012-01-25 09:18:53]

Hi Nicolas,

Thank you for taking a look.

Cheers,
Peter

https://chromiumcodereview.appspot.com/9283031/diff/1/dart/frog/leg/elements/...
File dart/frog/leg/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/9283031/diff/1/dart/frog/leg/elements/...
dart/frog/leg/elements/elements.dart:89: class EnclosingElement extends Element
{
On 2012/01/25 09:04:59, ngeoffray wrote:
> EnclosingElement -> ContainerElement?
> 
> Because other elements can be enclosing (eg a method), calling this class
> EnclosingElement makes things confusing.

I was planning on making the other elements subclasses of EnclosingElement. But
now I'm not sure that is a good idea. addMember is not an integral property of
what it means to be an EnclosingElement.

https://chromiumcodereview.appspot.com/9283031/diff/1/dart/frog/leg/elements/...
dart/frog/leg/elements/elements.dart:112: if (existing !== element) {
On 2012/01/25 09:04:59, ngeoffray wrote:
> Is this the right place to do it? Do we want a per-compilation unit error, or
a
> per-library error? It looks to me that the library will have to create the
scope
> and run through the topLevelElements of its compilation units, in order to
> report duplicates.

You're right, there is not much value in reporting duplicates at this point. I
should remove the scope from compilation unit.

[ahe, 2012-01-25 09:28:53]

https://chromiumcodereview.appspot.com/9283031/diff/1/dart/frog/leg/elements/...
File dart/frog/leg/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/9283031/diff/1/dart/frog/leg/elements/...
dart/frog/leg/elements/elements.dart:89: class EnclosingElement extends Element
{
On 2012/01/25 09:04:59, ngeoffray wrote:
> EnclosingElement -> ContainerElement?
> 
> Because other elements can be enclosing (eg a method), calling this class
> EnclosingElement makes things confusing.

Done.

https://chromiumcodereview.appspot.com/9283031/diff/1/dart/frog/leg/elements/...
dart/frog/leg/elements/elements.dart:112: if (existing !== element) {
On 2012/01/25 09:04:59, ngeoffray wrote:
> Is this the right place to do it? Do we want a per-compilation unit error, or
a
> per-library error? It looks to me that the library will have to create the
scope
> and run through the topLevelElements of its compilation units, in order to
> report duplicates.

Done.

https://chromiumcodereview.appspot.com/9283031/diff/1/dart/frog/leg/universe....
File dart/frog/leg/universe.dart (right):

https://chromiumcodereview.appspot.com/9283031/diff/1/dart/frog/leg/universe....
dart/frog/leg/universe.dart:31: Element existing =
elements.putIfAbsent(element.name, ()=>element);
On 2012/01/25 09:04:59, ngeoffray wrote:
> spaces around => ?

Done.