Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Unified Diff: dart/frog/leg/elements/elements.dart

Issue 9283031: Build script tags. (Closed) Base URL: ssh://aaricia.aar/home/ahe/Dart/all/dart.googlecode.com.git@script
Patch Set: Address review comments Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/compiler.dart ('k') | dart/frog/leg/resolver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/elements/elements.dart
diff --git a/dart/frog/leg/elements/elements.dart b/dart/frog/leg/elements/elements.dart
index 72fd376866d0b19decfb39bc815b5f247b635a3b..4e1785191ef3ce7f312f16b0571f17e857ddefd2 100644
--- a/dart/frog/leg/elements/elements.dart
+++ b/dart/frog/leg/elements/elements.dart
@@ -50,7 +50,6 @@ class Element implements Hashable {
final Element enclosingElement;
Modifiers get modifiers() => null;
-
Node parseNode(Canceler canceler, Logger logger) {
canceler.cancel("Internal Error: Element.parseNode");
}
@@ -87,13 +86,31 @@ class Element implements Hashable {
toString() => '$kind($name)';
}
-class CompilationUnitElement extends Element {
+class ContainerElement extends Element {
+ ContainerElement(name, kind, enclosingElement) :
+ super(name, kind, enclosingElement);
+
+ abstract void addMember(Element element, Canceler canceler);
+}
+
+class CompilationUnitElement extends ContainerElement {
final Script script;
+ Link<Element> topLevelElements = const EmptyLink<Element>();
+ Link<ScriptTag> tags = const EmptyLink<ScriptTag>();
+
CompilationUnitElement(Script script, Element enclosing)
: super(new SourceString(script.name),
ElementKind.COMPILATION_UNIT,
enclosing),
this.script = script;
+
+ void addMember(Element element, Canceler canceler) {
+ topLevelElements = topLevelElements.prepend(element);
+ }
+
+ void addTag(ScriptTag tag) {
+ tags = tags.prepend(tag);
+ }
}
class VariableElement extends Element {
@@ -329,7 +346,7 @@ class SynthesizedConstructorElement extends FunctionElement {
Token position() => null;
}
-class ClassElement extends Element {
+class ClassElement extends ContainerElement {
Type type;
Type supertype;
Link<Element> members = const EmptyLink<Element>();
@@ -347,7 +364,7 @@ class ClassElement extends Element {
constructors = new Map<SourceString, Element>(),
super(name, ElementKind.CLASS, enclosing);
- void addMember(Element element) {
+ void addMember(Element element, Canceler canceler) {
members = members.prepend(element);
if (element.kind == ElementKind.GENERATIVE_CONSTRUCTOR ||
element.modifiers.isFactory()) {
« no previous file with comments | « dart/frog/leg/compiler.dart ('k') | dart/frog/leg/resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698