Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 9271019: Make NodeList methods return NodeLists rather than List<Node>. (Closed)

Created:
8 years, 11 months ago by nweiz
Modified:
8 years, 11 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make NodeList methods return NodeLists rather than List<Node>. Committed: https://code.google.com/p/dart/source/detail?r=3508

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -4 lines) Patch
M client/html/release/html.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M client/html/release/htmlimpl.dart View 3 chunks +65 lines, -2 lines 0 comments Download
M client/html/src/NodeList.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M client/html/src/NodeWrappingImplementation.dart View 3 chunks +65 lines, -2 lines 0 comments Download
M client/tests/client/html/NodeTests.dart View 3 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
nweiz
8 years, 11 months ago (2012-01-20 22:30:54 UTC) #1
Jacob
8 years, 11 months ago (2012-01-21 01:23:41 UTC) #2
lgtm

LGTM
Next up, the same thing needs to happen for ElementList.

Powered by Google App Engine
This is Rietveld 408576698