Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: client/tests/client/html/NodeTests.dart

Issue 9271019: Make NodeList methods return NodeLists rather than List<Node>. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/html/src/NodeWrappingImplementation.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/tests/client/html/NodeTests.dart
diff --git a/client/tests/client/html/NodeTests.dart b/client/tests/client/html/NodeTests.dart
index ced2616c82961392eb992c7e34d1d206ea14480f..3ed00b65e9549a777a637dc3029f2c2225b9eb84 100644
--- a/client/tests/client/html/NodeTests.dart
+++ b/client/tests/client/html/NodeTests.dart
@@ -9,6 +9,10 @@ Node makeNodeWithChildren() =>
void testNode() {
group('nodes', () {
+ test('is a NodeList', () {
+ Expect.isTrue(makeNodeWithChildren().nodes is NodeList);
+ });
+
test('first', () {
var node = makeNodeWithChildren();
Expect.isTrue(node.nodes.first is Text);
@@ -32,6 +36,7 @@ void testNode() {
var filtered = makeNodeWithChildren().nodes.filter((n) => n is BRElement);
Expect.equals(1, filtered.length);
Expect.isTrue(filtered[0] is BRElement);
+ Expect.isTrue(filtered is NodeList);
});
test('every', () {
@@ -122,5 +127,34 @@ void testNode() {
Expect.isTrue(node.nodes.removeLast() is BRElement);
Expect.equals(1, node.nodes.length);
});
+
+ test('getRange', () {
+ var node = makeNodeWithChildren();
+ Expect.isTrue(node.nodes.getRange(1, 2) is NodeList);
+ });
+ });
+
+ group('_NodeList', () {
+ NodeList makeNodeList() =>
+ makeNodeWithChildren().nodes.filter((_) => true);
+
+ test('first', () {
+ var nodes = makeNodeList();
+ Expect.isTrue(nodes.first is Text);
+ });
+
+ test('filter', () {
+ var filtered = makeNodeList().filter((n) => n is BRElement);
+ Expect.equals(1, filtered.length);
+ Expect.isTrue(filtered[0] is BRElement);
+ Expect.isTrue(filtered is NodeList);
+ });
+
+ test('getRange', () {
+ var range = makeNodeList().getRange(1, 2);
+ Expect.isTrue(range is NodeList);
+ Expect.isTrue(range[0] is BRElement);
+ Expect.isTrue(range[1] is Comment);
+ });
});
}
« no previous file with comments | « client/html/src/NodeWrappingImplementation.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698