Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9264057: Refresh dart:dom libraries from WebKit (Closed)

Created:
8 years, 10 months ago by sra1
Modified:
8 years, 10 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Refresh dart:dom libraries from WebKit BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3706

Patch Set 1 #

Patch Set 2 : Uint8ClampedArray fixes #

Patch Set 3 : parameterize boilerplate with type to avoid static override error #

Patch Set 4 : Don't re-implement List<>, causes code that dartc rejects due to static 'override' #

Total comments: 3

Patch Set 5 : CR changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+677 lines, -199 lines) Patch
M client/dom/dom.dart View 8 chunks +8 lines, -0 lines 0 comments Download
M client/dom/dom_frog.dart View 8 chunks +8 lines, -0 lines 0 comments Download
M client/dom/frog/dom_frog.dart View 1 2 3 4 46 chunks +166 lines, -54 lines 0 comments Download
M client/dom/generated/src/frog/DOMApplicationCache.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/DOMWindow.dart View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/DataTransferItemList.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/frog/DeviceOrientationEvent.dart View 1 chunk +3 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/EventSource.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/Float32Array.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/frog/Float64Array.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
A client/dom/generated/src/frog/HTMLContentElement.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/IDBCursor.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/frog/IDBObjectStore.dart View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/InjectedScriptHost.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/frog/InspectorFrontendHost.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/Int16Array.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/frog/Int32Array.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/frog/Int8Array.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
A client/dom/generated/src/frog/ShadowRoot.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/Uint16Array.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/frog/Uint32Array.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/frog/Uint8Array.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
A client/dom/generated/src/frog/Uint8ClampedArray.dart View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/WebGLRenderingContext.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A client/dom/generated/src/frog/WebKitCSSRegionRule.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/WebSocket.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/Worker.dart View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/interface/DOMApplicationCache.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/DOMWindow.dart View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/interface/DataTransferItemList.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/interface/DeviceOrientationEvent.dart View 1 chunk +3 lines, -1 line 0 comments Download
M client/dom/generated/src/interface/EventSource.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A + client/dom/generated/src/interface/HTMLContentElement.dart View 1 chunk +3 lines, -7 lines 0 comments Download
M client/dom/generated/src/interface/IDBCursor.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/interface/IDBObjectStore.dart View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/interface/InjectedScriptHost.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/interface/InspectorFrontendHost.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A + client/dom/generated/src/interface/ShadowRoot.dart View 1 chunk +2 lines, -8 lines 0 comments Download
A + client/dom/generated/src/interface/Uint8ClampedArray.dart View 1 2 3 1 chunk +7 lines, -5 lines 0 comments Download
M client/dom/generated/src/interface/WebGLRenderingContext.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A + client/dom/generated/src/interface/WebKitCSSRegionRule.dart View 1 chunk +2 lines, -8 lines 0 comments Download
M client/dom/generated/src/interface/WebSocket.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/Worker.dart View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMApplicationCacheWrappingImplementation.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMWindowWrappingImplementation.dart View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_DataTransferItemListWrappingImplementation.dart View 1 chunk +15 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_DeviceOrientationEventWrappingImplementation.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M client/dom/generated/src/wrapping/_EventSourceWrappingImplementation.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A client/dom/generated/src/wrapping/_HTMLContentElementWrappingImplementation.dart View 1 chunk +21 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_IDBCursorWrappingImplementation.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/wrapping/_IDBObjectStoreWrappingImplementation.dart View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_InjectedScriptHostWrappingImplementation.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M client/dom/generated/src/wrapping/_InspectorFrontendHostWrappingImplementation.dart View 1 chunk +6 lines, -0 lines 0 comments Download
A client/dom/generated/src/wrapping/_ShadowRootWrappingImplementation.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A client/dom/generated/src/wrapping/_Uint8ClampedArrayWrappingImplementation.dart View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_WebGLRenderingContextWrappingImplementation.dart View 1 chunk +12 lines, -0 lines 0 comments Download
A client/dom/generated/src/wrapping/_WebKitCSSRegionRuleWrappingImplementation.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_WebSocketWrappingImplementation.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_WorkerWrappingImplementation.dart View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M client/dom/generated/wrapping_dom.js View 18 chunks +138 lines, -6 lines 0 comments Download
M client/dom/generated/wrapping_dom_externs.js View 1 10 chunks +12 lines, -10 lines 0 comments Download
M client/dom/idl/dart/dart.idl View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download
M client/dom/scripts/dartgenerator.py View 1 2 3 4 4 chunks +11 lines, -7 lines 0 comments Download
M client/dom/scripts/fremontcutbuilder.py View 1 chunk +19 lines, -18 lines 0 comments Download
M client/dom/src/_FactoryProviders.dart View 1 1 chunk +11 lines, -7 lines 0 comments Download
M client/dom/src/frog_FactoryProviders.dart View 1 2 chunks +4 lines, -0 lines 0 comments Download
M client/dom/templates/dom/wrapping/wrapping_dom.js View 1 1 chunk +8 lines, -0 lines 0 comments Download
M client/dom/wrapping_dom.dart View 8 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
8 years, 10 months ago (2012-01-31 02:35:02 UTC) #1
vsm
8 years, 10 months ago (2012-01-31 02:41:40 UTC) #2 
LGTM

https://chromiumcodereview.appspot.com/9264057/diff/4069/client/dom/scripts/d...
File client/dom/scripts/dartgenerator.py (right):

https://chromiumcodereview.appspot.com/9264057/diff/4069/client/dom/scripts/d...
client/dom/scripts/dartgenerator.py:47: 'SerializedScriptValue':
'Dynamic/*SerializedScriptValue*/',
Not sure it's useful to put this in the comment if we don't define what a
SerializedScriptValue is.

https://chromiumcodereview.appspot.com/9264057/diff/4069/client/dom/scripts/d...
client/dom/scripts/dartgenerator.py:756: #return MaybeListElementType(interface)
Delete comment.

https://chromiumcodereview.appspot.com/9264057/diff/4069/client/dom/src/_Fact...
File client/dom/src/_FactoryProviders.dart (left):

https://chromiumcodereview.appspot.com/9264057/diff/4069/client/dom/src/_Fact...
client/dom/src/_FactoryProviders.dart:61: static Float32Array _I16(arg) native;
Oops!

Powered by Google App Engine
This is Rietveld 408576698