Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 9225008: Fix a perfrormance degradation in Mandelbrot: double comparison may have (Closed)

Created:
8 years, 11 months ago by srdjan
Modified:
8 years, 11 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix a perfrormance degradation in Mandelbrot: double comparison may have left and right temporary objects. Committed: https://code.google.com/p/dart/source/detail?r=3660

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M runtime/vm/opt_code_generator_ia32.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
8 years, 11 months ago (2012-01-27 01:21:59 UTC) #1
siva
LGTM. One question if most of the nodes can handle temp would make sense to ...
8 years, 11 months ago (2012-01-27 01:35:17 UTC) #2
srdjan
8 years, 11 months ago (2012-01-27 16:15:46 UTC) #3
On 2012/01/27 01:35:17, asiva wrote:
> LGTM.
> 
> One question if most of the nodes can handle temp would make sense to invert
the
> default initialization to true and set it to false only in those nodes where
it
> cannot handle it.

Actually most nodes cannot handle temp (e.g., return node, store field , store
indexed, store static), but that is not a problem as they do not pass
CodeGenInfo .. yet. Therefore, I think that I should keep the default false.

Powered by Google App Engine
This is Rietveld 408576698