Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: runtime/vm/opt_code_generator_ia32.cc

Issue 9225008: Fix a perfrormance degradation in Mandelbrot: double comparison may have (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/opt_code_generator_ia32.cc
===================================================================
--- runtime/vm/opt_code_generator_ia32.cc (revision 3639)
+++ runtime/vm/opt_code_generator_ia32.cc (working copy)
@@ -2277,6 +2277,8 @@
const Bool& bool_false = Bool::ZoneHandle(Bool::False());
CodeGenInfo left_info(node->left());
CodeGenInfo right_info(node->right());
+ left_info.set_allow_temp(true);
+ right_info.set_allow_temp(true);
VisitLoadTwo(node->left(), node->right(), EAX, EDX);
DeoptimizationBlob* deopt_blob = NULL;
if (!left_info.IsClass(double_class_) || !right_info.IsClass(double_class_)) {
@@ -2370,7 +2372,7 @@
}
// Fall through if condition is not supported.
} else if (AtIdNodeHasClassAt(node, node->id(), double_class_, 0)) {
- // Double comparison
+ // Double comparison.
if (GenerateDoubleComparison(node)) {
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698